chore: fix formatting issues in logp printf-style calls #45944

mauri870 · 2025-08-12T18:44:39Z

Proposed commit message

This PR fixes fatal go vet errors on calls to logp functions. Release v0.22.1 of elastic-agent-libs enabled proper go vet support for printf style calls in logp, and that uncovered many misuses of printing directives.

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test

$ go get -u github.com/elastic/[email protected]
$ go vet ./...

Related issues

Relates logp: enable go vet checks for printf directives elastic-agent-libs#340.

github-actions · 2025-08-12T18:44:47Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

mergify · 2025-08-12T18:45:20Z

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @mauri870? 🙏.
For such, you'll need to label your PR with:

The upcoming major version of the Elastic Stack
The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
backport-active-all is the label that automatically backports to all active branches.
backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

elasticmachine · 2025-08-12T18:47:05Z

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

github-actions · 2025-08-20T19:42:26Z

@Mergifyio backport 9.0 9.1

mergify · 2025-08-20T19:42:35Z

backport 9.0 9.1

✅ Backports have been created

#46122 [9.0](backport #45944) chore: fix formatting issues in logp printf-style calls has been created for branch 9.0 but encountered conflicts
#46123 [9.1](backport #45944) chore: fix formatting issues in logp printf-style calls has been created for branch 9.1 but encountered conflicts

* fix go vet errors for logp formatting issues * chore: fix formatting for logp calls * revert elastic-agent-libs bump * Apply suggestions from code review Co-authored-by: Tiago Queiroz <[email protected]> --------- Co-authored-by: Tiago Queiroz <[email protected]> Co-authored-by: Blake Rouse <[email protected]> (cherry picked from commit a5be2a8) # Conflicts: # filebeat/input/journald/input.go # filebeat/input/log/input.go # libbeat/autodiscover/appenders/config/config.go # libbeat/autodiscover/template/config.go # libbeat/conditions/range.go # libbeat/scripts/cmd/stress_pipeline/main.go # metricbeat/module/kafka/consumergroup/query.go # metricbeat/module/kafka/partition/partition.go # metricbeat/module/kubernetes/util/kubernetes.go # metricbeat/module/linux/rapl/rapl.go # x-pack/filebeat/input/awss3/sqs_s3_event.go # x-pack/metricbeat/module/meraki/device_health/device_health.go # x-pack/metricbeat/module/meraki/http.go # x-pack/metricbeat/module/prometheus/remote_write/data.go

* fix go vet errors for logp formatting issues * chore: fix formatting for logp calls * revert elastic-agent-libs bump * Apply suggestions from code review Co-authored-by: Tiago Queiroz <[email protected]> --------- Co-authored-by: Tiago Queiroz <[email protected]> Co-authored-by: Blake Rouse <[email protected]> (cherry picked from commit a5be2a8) # Conflicts: # libbeat/autodiscover/appenders/config/config.go # libbeat/autodiscover/template/config.go # x-pack/filebeat/input/awss3/sqs_s3_event.go # x-pack/metricbeat/module/prometheus/remote_write/data.go

* fix go vet errors for logp formatting issues * chore: fix formatting for logp calls * revert elastic-agent-libs bump * Apply suggestions from code review Co-authored-by: Tiago Queiroz <[email protected]> --------- Co-authored-by: Tiago Queiroz <[email protected]> Co-authored-by: Blake Rouse <[email protected]> (cherry picked from commit a5be2a8) # Conflicts: # metricbeat/module/kubernetes/util/kubernetes.go # x-pack/filebeat/input/awss3/sqs_s3_event.go

…yle calls (#46122) * chore: fix formatting issues in logp printf-style calls (#45944) * fix go vet errors for logp formatting issues * chore: fix formatting for logp calls * revert elastic-agent-libs bump * Apply suggestions from code review Co-authored-by: Tiago Queiroz <[email protected]> --------- Co-authored-by: Tiago Queiroz <[email protected]> Co-authored-by: Blake Rouse <[email protected]> (cherry picked from commit a5be2a8) # Conflicts: # filebeat/input/journald/input.go # filebeat/input/log/input.go # libbeat/autodiscover/appenders/config/config.go # libbeat/autodiscover/template/config.go # libbeat/conditions/range.go # libbeat/scripts/cmd/stress_pipeline/main.go # metricbeat/module/kafka/consumergroup/query.go # metricbeat/module/kafka/partition/partition.go # metricbeat/module/kubernetes/util/kubernetes.go # metricbeat/module/linux/rapl/rapl.go # x-pack/filebeat/input/awss3/sqs_s3_event.go # x-pack/metricbeat/module/meraki/device_health/device_health.go # x-pack/metricbeat/module/meraki/http.go # x-pack/metricbeat/module/prometheus/remote_write/data.go * fix conflicts * remove file not present in branch --------- Co-authored-by: Mauri de Souza Meneguzzo <[email protected]> Co-authored-by: Khushi Jain <[email protected]>

…yle calls (#46123) * chore: fix formatting issues in logp printf-style calls (#45944) * fix go vet errors for logp formatting issues * chore: fix formatting for logp calls * revert elastic-agent-libs bump * Apply suggestions from code review Co-authored-by: Tiago Queiroz <[email protected]> --------- Co-authored-by: Tiago Queiroz <[email protected]> Co-authored-by: Blake Rouse <[email protected]> (cherry picked from commit a5be2a8) # Conflicts: # libbeat/autodiscover/appenders/config/config.go # libbeat/autodiscover/template/config.go # x-pack/filebeat/input/awss3/sqs_s3_event.go # x-pack/metricbeat/module/prometheus/remote_write/data.go * fix conflicts --------- Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>

…tyle calls (#46124) * chore: fix formatting issues in logp printf-style calls (#45944) * fix go vet errors for logp formatting issues * chore: fix formatting for logp calls * revert elastic-agent-libs bump * Apply suggestions from code review Co-authored-by: Tiago Queiroz <[email protected]> --------- Co-authored-by: Tiago Queiroz <[email protected]> Co-authored-by: Blake Rouse <[email protected]> (cherry picked from commit a5be2a8) # Conflicts: # metricbeat/module/kubernetes/util/kubernetes.go # x-pack/filebeat/input/awss3/sqs_s3_event.go * fix conflicts --------- Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>

github-actions · 2025-10-02T12:58:32Z

@Mergifyio backport 8.18 8.19 9.0 9.1 9.2

mergify · 2025-10-02T12:58:43Z

backport 8.18 8.19 9.0 9.1 9.2

✅ Backports have been created

#46907 [8.18](backport #45944) chore: fix formatting issues in logp printf-style calls has been created for branch 8.18 but encountered conflicts
#46124 [8.19](backport #45944) chore: fix formatting issues in logp printf-style calls has been created for branch 8.19
#46122 [9.0](backport #45944) chore: fix formatting issues in logp printf-style calls has been created for branch 9.0
#46123 [9.1](backport #45944) chore: fix formatting issues in logp printf-style calls has been created for branch 9.1
#46908 [9.2](backport #45944) chore: fix formatting issues in logp printf-style calls has been created for branch 9.2 but encountered conflicts

* fix go vet errors for logp formatting issues * chore: fix formatting for logp calls * revert elastic-agent-libs bump * Apply suggestions from code review Co-authored-by: Tiago Queiroz <[email protected]> --------- Co-authored-by: Tiago Queiroz <[email protected]> Co-authored-by: Blake Rouse <[email protected]> (cherry picked from commit a5be2a8) # Conflicts: # filebeat/input/log/input.go # libbeat/autodiscover/appenders/config/config.go # libbeat/autodiscover/template/config.go # libbeat/conditions/range.go # libbeat/scripts/cmd/stress_pipeline/main.go # metricbeat/module/kafka/consumergroup/query.go # metricbeat/module/kafka/partition/partition.go # metricbeat/module/kubernetes/util/kubernetes.go # metricbeat/module/linux/rapl/rapl.go # x-pack/filebeat/input/awss3/sqs_s3_event.go # x-pack/metricbeat/module/meraki/device_health/device_health.go # x-pack/metricbeat/module/meraki/http.go # x-pack/metricbeat/module/prometheus/remote_write/data.go

* fix go vet errors for logp formatting issues * chore: fix formatting for logp calls * revert elastic-agent-libs bump * Apply suggestions from code review Co-authored-by: Tiago Queiroz <[email protected]> --------- Co-authored-by: Tiago Queiroz <[email protected]> Co-authored-by: Blake Rouse <[email protected]> (cherry picked from commit a5be2a8) # Conflicts: # libbeat/processors/add_host_metadata/add_host_metadata.go

mauri870 added 3 commits August 11, 2025 13:19

fix go vet errors for logp formatting issues

396120a

Merge branch 'main' into go-vet-logp

efc5252

chore: fix formatting for logp calls

444e42b

mauri870 self-assigned this Aug 12, 2025

mauri870 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Aug 12, 2025

botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Aug 12, 2025

mauri870 changed the title ~~chore: fix formatting for logp calls~~ chore: fix formatting issues in logp printf-style calls Aug 12, 2025

revert elastic-agent-libs bump

578ea0d

mauri870 force-pushed the go-vet-logp branch from 1531ee8 to 578ea0d Compare August 12, 2025 18:46

mauri870 marked this pull request as ready for review August 12, 2025 18:47

mauri870 requested review from a team as code owners August 12, 2025 18:47

mauri870 requested review from leehinman and khushijain21 August 12, 2025 18:47

mauri870 requested review from michalpristas and pchila August 12, 2025 18:47

mauri870 added backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches backport-8.19 Automated backport to the 8.19 branch labels Aug 12, 2025

taylor-swanson approved these changes Aug 13, 2025

View reviewed changes

AndersonQ mentioned this pull request Aug 13, 2025

[filebeat] update changelog: add fix panic when registering metrics #45967

Merged

cmacknz merged commit a5be2a8 into elastic:main Aug 20, 2025
206 of 212 checks passed

mergify bot mentioned this pull request Aug 20, 2025

[9.0](backport #45944) chore: fix formatting issues in logp printf-style calls #46122

Merged

6 tasks

mergify bot mentioned this pull request Aug 20, 2025

[9.1](backport #45944) chore: fix formatting issues in logp printf-style calls #46123

Merged

6 tasks

mergify bot mentioned this pull request Aug 20, 2025

[8.19](backport #45944) chore: fix formatting issues in logp printf-style calls #46124

Merged

6 tasks

mauri870 mentioned this pull request Sep 4, 2025

chore: fix formatting issues in logp printf-style calls elastic/elastic-agent#9732

Merged

6 tasks

khushijain21 mentioned this pull request Sep 5, 2025

chore: fix formatting issues in logp printf-style calls elastic/elastic-agent#9757

Merged

6 tasks

khushijain21 mentioned this pull request Sep 29, 2025

[8.18](backport #46054) [Chore] Accomodate breaking from elastic-agent-libs and elastic-agent-system-metrics #46423

Open

6 tasks

mauri870 added the backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches label Oct 2, 2025

mauri870 added backport-8.18 Automated backport to the 8.18 branch and removed backport-active-8 Automated backport with mergify to all the active 8.[0-9]+ branches labels Oct 2, 2025

mergify bot mentioned this pull request Oct 2, 2025

[8.18](backport #45944) chore: fix formatting issues in logp printf-style calls #46907

Open

6 tasks

mergify bot mentioned this pull request Oct 2, 2025

[9.2](backport #45944) chore: fix formatting issues in logp printf-style calls #46908

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: fix formatting issues in logp printf-style calls #45944

chore: fix formatting issues in logp printf-style calls #45944

Uh oh!

mauri870 commented Aug 12, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Aug 12, 2025

Uh oh!

mergify bot commented Aug 12, 2025

Uh oh!

elasticmachine commented Aug 12, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

mergify bot commented Aug 20, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

mergify bot commented Oct 2, 2025 •

edited

Loading

Uh oh!

Uh oh!

chore: fix formatting issues in logp printf-style calls #45944

chore: fix formatting issues in logp printf-style calls #45944

Uh oh!

Conversation

mauri870 commented Aug 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed commit message

Checklist

How to test

Related issues

Uh oh!

github-actions bot commented Aug 12, 2025

🤖 GitHub comments

Uh oh!

mergify bot commented Aug 12, 2025

Uh oh!

elasticmachine commented Aug 12, 2025

Uh oh!

Uh oh!

github-actions bot commented Aug 20, 2025

Uh oh!

mergify bot commented Aug 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

github-actions bot commented Oct 2, 2025

Uh oh!

mergify bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Backports have been created

Uh oh!

Uh oh!

mauri870 commented Aug 12, 2025 •

edited

Loading

mergify bot commented Aug 20, 2025 •

edited

Loading

mergify bot commented Oct 2, 2025 •

edited

Loading