Skip to content

Conversation

khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented Sep 5, 2025

Proposed commit message

This PR fixes fatal go vet errors on calls to logp functions. Release v0.22.1 of elastic-agent-libs enabled proper go vet support for printf style calls in logp, and that uncovered many misuses of printing directives.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test

$ go get -u github.com/elastic/[email protected]
$ go vet ./...

Related issues

@khushijain21 khushijain21 requested a review from a team as a code owner September 5, 2025 07:53
Copy link
Contributor

mergify bot commented Sep 5, 2025

This pull request does not have a backport label. Could you fix it @khushijain21? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@pierrehilbert pierrehilbert added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Sep 5, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

Copy link

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

cc @khushijain21

@mauri870
Copy link
Member

mauri870 commented Sep 5, 2025

Strange that CI did not complain about this single case in my previous PR. Thanks for fixing it!

@khushijain21 khushijain21 enabled auto-merge (squash) September 5, 2025 11:44
@khushijain21 khushijain21 merged commit a47be25 into elastic:main Sep 5, 2025
27 of 28 checks passed
@khushijain21 khushijain21 added backport-8.19 Automated backport to the 8.19 branch backport-9.1 Automated backport to the 9.1 branch backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches and removed backport-9.1 Automated backport to the 9.1 branch labels Sep 5, 2025
Copy link
Contributor

github-actions bot commented Sep 5, 2025

@Mergifyio backport 9.0 9.1

Copy link
Contributor

mergify bot commented Sep 5, 2025

backport 9.0 9.1

✅ Backports have been created

khushijain21 added a commit that referenced this pull request Sep 5, 2025
khushijain21 added a commit that referenced this pull request Sep 5, 2025
intxgo pushed a commit to intxgo/elastic-agent that referenced this pull request Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.19 Automated backport to the 8.19 branch backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants