logp: enable go vet checks for printf directives #340
Merged
+22
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently, misuse of printf directives in logger functions is not reported by go vet. Use a small trick to enable the
x/tools/go/analysis/passes/printf
analyzer on printf wrappers, allowing this check to catch format string issues.See https://pkg.go.dev/golang.org/x/tools/go/analysis/passes/printf#hdr-Inferred_printf_wrappers
Why is it important?
Reports misuse of printing directives in the logger functions.
Checklist