Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Oct 2, 2025

Proposed commit message

This PR fixes fatal go vet errors on calls to logp functions. Release v0.22.1 of elastic-agent-libs enabled proper go vet support for printf style calls in logp, and that uncovered many misuses of printing directives.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test

$ go get -u github.com/elastic/[email protected]
$ go vet ./...

Related issues


This is an automatic backport of pull request #45944 done by [Mergify](https://mergify.com).

* fix go vet errors for logp formatting issues

* chore: fix formatting for logp calls

* revert elastic-agent-libs bump

* Apply suggestions from code review

Co-authored-by: Tiago Queiroz <[email protected]>

---------

Co-authored-by: Tiago Queiroz <[email protected]>
Co-authored-by: Blake Rouse <[email protected]>
(cherry picked from commit a5be2a8)

# Conflicts:
#	filebeat/input/log/input.go
#	libbeat/autodiscover/appenders/config/config.go
#	libbeat/autodiscover/template/config.go
#	libbeat/conditions/range.go
#	libbeat/scripts/cmd/stress_pipeline/main.go
#	metricbeat/module/kafka/consumergroup/query.go
#	metricbeat/module/kafka/partition/partition.go
#	metricbeat/module/kubernetes/util/kubernetes.go
#	metricbeat/module/linux/rapl/rapl.go
#	x-pack/filebeat/input/awss3/sqs_s3_event.go
#	x-pack/metricbeat/module/meraki/device_health/device_health.go
#	x-pack/metricbeat/module/meraki/http.go
#	x-pack/metricbeat/module/prometheus/remote_write/data.go
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Oct 2, 2025
@mergify mergify bot requested review from a team as code owners October 2, 2025 13:33
@mergify mergify bot added the backport label Oct 2, 2025
@mergify mergify bot requested a review from a team as a code owner October 2, 2025 13:33
@mergify mergify bot added the conflicts There is a conflict in the backported pull request label Oct 2, 2025
@mergify mergify bot requested review from belimawr and orestisfl and removed request for a team October 2, 2025 13:33
Copy link
Contributor Author

mergify bot commented Oct 2, 2025

Cherry-pick of a5be2a8 has failed:

On branch mergify/bp/8.18/pr-45944
Your branch is up to date with 'origin/8.18'.

You are currently cherry-picking commit a5be2a856.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   auditbeat/helper/hasher/cached_hasher.go
	modified:   auditbeat/module/auditd/audit_linux.go
	modified:   filebeat/autodiscover/builder/hints/logs.go
	modified:   filebeat/input/filestream/copytruncate_prospector.go
	modified:   filebeat/input/filestream/filestream.go
	modified:   filebeat/input/filestream/internal/input-logfile/harvester.go
	modified:   filebeat/input/filestream/internal/input-logfile/publish.go
	modified:   filebeat/input/filestream/internal/input-logfile/update_writer.go
	modified:   filebeat/input/journald/input.go
	modified:   filebeat/input/unix/input.go
	modified:   heartbeat/autodiscover/builder/hints/monitors.go
	modified:   heartbeat/beater/heartbeat.go
	modified:   heartbeat/monitors/active/icmp/stdloop.go
	modified:   heartbeat/monitors/factory.go
	modified:   heartbeat/monitors/monitor.go
	modified:   heartbeat/scheduler/schedjob.go
	modified:   libbeat/autodiscover/providers/kubernetes/kubernetes.go
	modified:   libbeat/processors/add_host_metadata/add_host_metadata.go
	modified:   libbeat/processors/add_kubernetes_metadata/kubernetes.go
	modified:   libbeat/publisher/queue/diskqueue/segments.go
	modified:   metricbeat/mb/lightmodules.go
	modified:   metricbeat/module/kubernetes/event/event.go
	modified:   metricbeat/module/kubernetes/state_container/state_container.go
	modified:   metricbeat/module/mysql/query/query.go
	modified:   metricbeat/module/system/diskio/diskio.go
	modified:   metricbeat/module/vsphere/cluster/cluster.go
	modified:   metricbeat/module/vsphere/datastore/datastore.go
	modified:   metricbeat/module/vsphere/datastorecluster/datastorecluster.go
	modified:   metricbeat/module/vsphere/host/host.go
	modified:   metricbeat/module/vsphere/network/network.go
	modified:   metricbeat/module/vsphere/resourcepool/resourcepool.go
	modified:   metricbeat/module/vsphere/virtualmachine/virtualmachine.go
	modified:   packetbeat/protos/dns/dns_tcp.go
	modified:   x-pack/auditbeat/module/system/socket/socket_linux.go
	modified:   x-pack/filebeat/input/awscloudwatch/input.go
	modified:   x-pack/filebeat/input/netflow/input.go
	modified:   x-pack/heartbeat/monitors/browser/sourcejob.go
	modified:   x-pack/heartbeat/monitors/browser/synthexec/synthexec.go
	modified:   x-pack/libbeat/common/cloudfoundry/dopplerconsumer.go
	modified:   x-pack/libbeat/management/managerV2.go
	modified:   x-pack/metricbeat/module/aws/awshealth/awshealth.go
	modified:   x-pack/metricbeat/module/aws/billing/billing.go
	modified:   x-pack/metricbeat/module/aws/cloudwatch/cloudwatch.go
	modified:   x-pack/metricbeat/module/azure/billing/data.go
	modified:   x-pack/metricbeat/module/containerd/memory/memory.go

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	both modified:   filebeat/input/log/input.go
	both modified:   libbeat/autodiscover/appenders/config/config.go
	both modified:   libbeat/autodiscover/template/config.go
	both modified:   libbeat/conditions/range.go
	both modified:   libbeat/scripts/cmd/stress_pipeline/main.go
	both modified:   metricbeat/module/kafka/consumergroup/query.go
	both modified:   metricbeat/module/kafka/partition/partition.go
	both modified:   metricbeat/module/kubernetes/util/kubernetes.go
	both modified:   metricbeat/module/linux/rapl/rapl.go
	both modified:   x-pack/filebeat/input/awss3/sqs_s3_event.go
	both modified:   x-pack/metricbeat/module/meraki/device_health/device_health.go
	deleted by us:   x-pack/metricbeat/module/meraki/http.go
	both modified:   x-pack/metricbeat/module/prometheus/remote_write/data.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2025
@mergify mergify bot requested review from ycombinator and pkoutsovasilis and removed request for a team October 2, 2025 13:33
@github-actions github-actions bot added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Oct 2, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@mauri870
Copy link
Member

mauri870 commented Oct 2, 2025

/test

@mauri870 mauri870 enabled auto-merge (squash) October 3, 2025 13:22
@mauri870
Copy link
Member

mauri870 commented Oct 3, 2025

@pierrehilbert The failures seems to be unrelated. The linter errors are because this touches many files, and the metricbeat integration tests are failing for kubernetes, which seems to happen often for backports. Can you force merge this if there are no blockers? Thanks.

@pierrehilbert
Copy link
Collaborator

Considering we are release a new version on Tuesday, we should probably wait for this to be released before merging stuff in case we are getting a new BC. WDYT?

@mauri870
Copy link
Member

mauri870 commented Oct 3, 2025

Considering we are release a new version on Tuesday, we should probably wait for this to be released before merging stuff in case we are getting a new BC. WDYT?

Good point, let's wait for the new BC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants