-
Notifications
You must be signed in to change notification settings - Fork 5k
[8.18](backport #45944) chore: fix formatting issues in logp printf-style calls #46907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 8.18
Are you sure you want to change the base?
Conversation
* fix go vet errors for logp formatting issues * chore: fix formatting for logp calls * revert elastic-agent-libs bump * Apply suggestions from code review Co-authored-by: Tiago Queiroz <[email protected]> --------- Co-authored-by: Tiago Queiroz <[email protected]> Co-authored-by: Blake Rouse <[email protected]> (cherry picked from commit a5be2a8) # Conflicts: # filebeat/input/log/input.go # libbeat/autodiscover/appenders/config/config.go # libbeat/autodiscover/template/config.go # libbeat/conditions/range.go # libbeat/scripts/cmd/stress_pipeline/main.go # metricbeat/module/kafka/consumergroup/query.go # metricbeat/module/kafka/partition/partition.go # metricbeat/module/kubernetes/util/kubernetes.go # metricbeat/module/linux/rapl/rapl.go # x-pack/filebeat/input/awss3/sqs_s3_event.go # x-pack/metricbeat/module/meraki/device_health/device_health.go # x-pack/metricbeat/module/meraki/http.go # x-pack/metricbeat/module/prometheus/remote_write/data.go
Cherry-pick of a5be2a8 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
/test |
@pierrehilbert The failures seems to be unrelated. The linter errors are because this touches many files, and the metricbeat integration tests are failing for kubernetes, which seems to happen often for backports. Can you force merge this if there are no blockers? Thanks. |
Considering we are release a new version on Tuesday, we should probably wait for this to be released before merging stuff in case we are getting a new BC. WDYT? |
Good point, let's wait for the new BC. |
Proposed commit message
This PR fixes fatal go vet errors on calls to logp functions. Release v0.22.1 of elastic-agent-libs enabled proper go vet support for printf style calls in logp, and that uncovered many misuses of printing directives.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test
Related issues
This is an automatic backport of pull request #45944 done by [Mergify](https://mergify.com).