chore: fix formatting issues in logp printf-style calls (#45944)

* fix go vet errors for logp formatting issues

* chore: fix formatting for logp calls

* revert elastic-agent-libs bump

* Apply suggestions from code review

Co-authored-by: Tiago Queiroz <[email protected]>

---------

Co-authored-by: Tiago Queiroz <[email protected]>
Co-authored-by: Blake Rouse <[email protected]>

Author: 3 people

auditbeat/helper/hasher/cached_hasher.go

@@ -126,7 +126,7 @@ func (ch *CachedHasher) HashFile(path string) (map[HashType]Digest, error) {
 	entry := hashEntry{hashes: hashes, statx: statx}
 	if ch.hashLRU.Add(path, entry) {
 		ch.stats.Evictions++
-		ch.log.Debugf("evict (%s)")
+		ch.log.Debugf("evict (%s)", path)
 	}
 
 	ch.log.Debugf("miss (%s) took %v", path, time.Since(x))

auditbeat/module/auditd/audit_linux.go

@@ -450,7 +450,7 @@ func (ms *MetricSet) updateKernelLostMetric(lost uint32) {
 		}
 		logFn("kernel lost events: %d (total: %d)", delta, lost)
 	} else {
-		ms.log.Warnf("kernel lost event counter reset from %d to %d", ms.kernelLost, lost)
+		ms.log.Warnf("kernel lost event counter reset from %d to %d", ms.kernelLost.counter, lost)
 	}
 	ms.kernelLost.counter = lost
 }

filebeat/autodiscover/builder/hints/logs.go

@@ -160,7 +160,7 @@ func (l *logHints) CreateConfig(event bus.Event, options ...ucfg.Option) []*conf
 		// Merge config template with the configs from the annotations
 		// AppendValues option is used to append arrays from annotations to existing arrays while merging
 		if err := config.MergeWithOpts(tempCfg, ucfg.AppendValues); err != nil {
-			l.log.Debugf("hints.builder", "config merge failed with error: %v", err)
+			l.log.Debugf("config merge failed with error: %v", err)
 			continue
 		}
 		module := l.getModule(hints)
@@ -191,11 +191,11 @@ func (l *logHints) CreateConfig(event bus.Event, options ...ucfg.Option) []*conf
 				moduleConf[fileset+".enabled"] = cfg.Enabled
 				moduleConf[fileset+".input"] = filesetConf
 
-				l.log.Debugf("hints.builder", "generated config %+v", moduleConf)
+				l.log.Debugf("generated config %+v", moduleConf)
 			}
 			config, _ = conf.NewConfigFrom(moduleConf)
 		}
-		l.log.Debugf("hints.builder", "generated config %+v of logHints %+v", config, l)
+		l.log.Debugf("generated config %+v of logHints %+v", config, l)
 		configs = append(configs, config)
 	}
 	// Apply information in event to the template to generate the final config

filebeat/input/filestream/copytruncate_prospector.go

@@ -280,7 +280,7 @@ func (p *copyTruncateFileProspector) onFSEvent(
 
 		err := updater.ResetCursor(src, state{Offset: 0})
 		if err != nil {
-			log.Errorf("failed to reset file cursor: %w", err)
+			log.Errorf("failed to reset file cursor: %v", err)
 		}
 		group.Restart(ctx, src)
 

filebeat/input/filestream/filestream.go

@@ -159,7 +159,7 @@ func (f *logFile) startFileMonitoringIfNeeded() {
 			return nil
 		})
 		if err != nil {
-			f.log.Errorf("failed to start file monitoring: %w", err)
+			f.log.Errorf("failed to start file monitoring: %v", err)
 		}
 	}
 
@@ -169,7 +169,7 @@ func (f *logFile) startFileMonitoringIfNeeded() {
 			return nil
 		})
 		if err != nil {
-			f.log.Errorf("failed to schedule a file close: %w", err)
+			f.log.Errorf("failed to schedule a file close: %v", err)
 		}
 	}
 }

filebeat/input/filestream/internal/input-logfile/harvester.go

@@ -138,7 +138,7 @@ func (hg *defaultHarvesterGroup) Start(ctx inputv2.Context, src Source) {
 
 	if err := hg.tg.Go(startHarvester(ctx, hg, src, false, hg.metrics)); err != nil {
 		ctx.Logger.Warnf(
-			"tried to start harvester with task group already closed",
+			"tried to start harvester for %s with task group already closed",
 			ctx.ID)
 	}
 }

filebeat/input/filestream/internal/input-logfile/publish.go

@@ -134,7 +134,7 @@ func (op *updateOp) Execute(store *store, n uint) {
 	} else {
 		err := typeconv.Convert(&resource.cursor, op.delta)
 		if err != nil {
-			store.log.Errorf("failed to perform type conversion: %w", err)
+			store.log.Errorf("failed to perform type conversion: %v", err)
 		}
 	}
 

filebeat/input/filestream/internal/input-logfile/update_writer.go

@@ -66,7 +66,7 @@ func newUpdateWriter(store *store, ch *updateChan) *updateWriter {
 		return nil
 	})
 	if err != nil {
-		store.log.Errorf("failed to schedule the update writer routine: %w", err)
+		store.log.Errorf("failed to schedule the update writer routine: %v", err)
 	}
 
 	return w
@@ -77,7 +77,7 @@ func newUpdateWriter(store *store, ch *updateChan) *updateWriter {
 func (w *updateWriter) Close() {
 	err := w.tg.Stop()
 	if err != nil {
-		w.store.log.Errorf("failed to stop the update writer routine: %w", err)
+		w.store.log.Errorf("failed to stop the update writer routine: %v", err)
 	}
 	w.syncStates(w.ch.TryRecv())
 }

filebeat/input/journald/input.go

@@ -216,7 +216,7 @@ func (inp *journald) Run(
 		if err := publisher.Publish(event, event.Private); err != nil {
 			msg := fmt.Sprintf("could not publish event: %s", err)
 			ctx.UpdateStatus(status.Failed, msg)
-			logger.Errorf(msg)
+			logger.Errorf("%s", msg)
 			return err
 		}
 	}

filebeat/input/log/input.go

@@ -107,7 +107,7 @@ func NewInput(
 	cleanupIfNeeded := func(f func() error) {
 		if cleanupNeeded {
 			if err := f(); err != nil {
-				logger.Named("input.log").Errorf("clean up function returned an error: %w", err)
+				logger.Named("input.log").Errorf("clean up function returned an error: %v", err)
 			}
 		}
 	}