[8.19](backport #45944) chore: fix formatting issues in logp printf-style calls

[mergify]

Proposed commit message

This PR fixes fatal go vet errors on calls to logp functions. Release v0.22.1 of elastic-agent-libs enabled proper go vet support for printf style calls in logp, and that uncovered many misuses of printing directives.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test

$ go get -u github.com/elastic/[email protected]
$ go vet ./...

Related issues

• Relates logp: enable go vet checks for printf directives elastic-agent-libs#340.

---

This is an automatic backport of pull request #45944 done by [Mergify](https://mergify.com).

[mergify]

Cherry-pick of a5be2a8 has failed:

On branch mergify/bp/8.19/pr-45944
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit a5be2a856.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   auditbeat/helper/hasher/cached_hasher.go
	modified:   auditbeat/module/auditd/audit_linux.go
	modified:   filebeat/autodiscover/builder/hints/logs.go
	modified:   filebeat/input/filestream/copytruncate_prospector.go
	modified:   filebeat/input/filestream/filestream.go
	modified:   filebeat/input/filestream/internal/input-logfile/harvester.go
	modified:   filebeat/input/filestream/internal/input-logfile/publish.go
	modified:   filebeat/input/filestream/internal/input-logfile/update_writer.go
	modified:   filebeat/input/journald/input.go
	modified:   filebeat/input/log/input.go
	modified:   filebeat/input/unix/input.go
	modified:   heartbeat/autodiscover/builder/hints/monitors.go
	modified:   heartbeat/beater/heartbeat.go
	modified:   heartbeat/monitors/active/icmp/stdloop.go
	modified:   heartbeat/monitors/factory.go
	modified:   heartbeat/monitors/monitor.go
	modified:   heartbeat/scheduler/schedjob.go
	modified:   libbeat/autodiscover/appenders/config/config.go
	modified:   libbeat/autodiscover/providers/kubernetes/kubernetes.go
	modified:   libbeat/autodiscover/template/config.go
	modified:   libbeat/conditions/range.go
	modified:   libbeat/processors/add_host_metadata/add_host_metadata.go
	modified:   libbeat/processors/add_kubernetes_metadata/kubernetes.go
	modified:   libbeat/publisher/queue/diskqueue/segments.go
	modified:   libbeat/scripts/cmd/stress_pipeline/main.go
	modified:   metricbeat/mb/lightmodules.go
	modified:   metricbeat/module/kafka/consumergroup/query.go
	modified:   metricbeat/module/kafka/partition/partition.go
	modified:   metricbeat/module/kubernetes/event/event.go
	modified:   metricbeat/module/kubernetes/state_container/state_container.go
	modified:   metricbeat/module/linux/rapl/rapl.go
	modified:   metricbeat/module/mysql/query/query.go
	modified:   metricbeat/module/system/diskio/diskio.go
	modified:   metricbeat/module/vsphere/cluster/cluster.go
	modified:   metricbeat/module/vsphere/datastore/datastore.go
	modified:   metricbeat/module/vsphere/datastorecluster/datastorecluster.go
	modified:   metricbeat/module/vsphere/host/host.go
	modified:   metricbeat/module/vsphere/network/network.go
	modified:   metricbeat/module/vsphere/resourcepool/resourcepool.go
	modified:   metricbeat/module/vsphere/virtualmachine/virtualmachine.go
	modified:   packetbeat/protos/dns/dns_tcp.go
	modified:   x-pack/auditbeat/module/system/socket/socket_linux.go
	modified:   x-pack/filebeat/input/awscloudwatch/input.go
	modified:   x-pack/filebeat/input/netflow/input.go
	modified:   x-pack/heartbeat/monitors/browser/sourcejob.go
	modified:   x-pack/heartbeat/monitors/browser/synthexec/synthexec.go
	modified:   x-pack/libbeat/common/cloudfoundry/dopplerconsumer.go
	modified:   x-pack/libbeat/management/managerV2.go
	modified:   x-pack/metricbeat/module/aws/awshealth/awshealth.go
	modified:   x-pack/metricbeat/module/aws/billing/billing.go
	modified:   x-pack/metricbeat/module/aws/cloudwatch/cloudwatch.go
	modified:   x-pack/metricbeat/module/azure/billing/data.go
	modified:   x-pack/metricbeat/module/containerd/memory/memory.go
	modified:   x-pack/metricbeat/module/meraki/device_health/device_health.go
	modified:   x-pack/metricbeat/module/meraki/http.go
	modified:   x-pack/metricbeat/module/prometheus/remote_write/data.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   metricbeat/module/kubernetes/util/kubernetes.go
	both modified:   x-pack/filebeat/input/awss3/sqs_s3_event.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[elasticmachine]

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.19/pr-45944 upstream/mergify/bp/8.19/pr-45944
git merge upstream/8.19
git push upstream mergify/bp/8.19/pr-45944

[mauri870]

/test

[mergify]

This pull request has not been merged yet. Could you please review and merge it @mauri870? 🙏

[mauri870]

/test

[mauri870]

/test

[khushijain21]

@mauri870 there is a known issue with 8.19 CI - which is that if your PR consists of changes made to both metricbeat/module/k8's files and any other module at the same time then metricbeat integration tests fail. I think this can be force merged instead.

cc: @pierrehilbert @cmacknz

[mergify]

This pull request has not been merged yet. Could you please review and merge it @mauri870? 🙏

[mauri870]

@mauri870 there is a known issue with 8.19 CI - which is that if your PR consists of changes made to both metricbeat/module/k8's files and any other module at the same time then metricbeat integration tests fail. I think this can be force merged instead.

Aha, thanks! I missed your comment at first and was digging into why this was failing. I’ll add it to my notes and ping them tomorrow since they’re out today.