Skip to content

Conversation

mauri870
Copy link
Member

@mauri870 mauri870 commented Sep 4, 2025

Proposed commit message

This PR fixes fatal go vet errors on calls to logp functions. Release v0.22.1 of elastic-agent-libs enabled proper go vet support for printf style calls in logp, and that uncovered many misuses of printing directives.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test

$ go get -u github.com/elastic/[email protected]
$ go vet ./...

Related issues

@mauri870 mauri870 self-assigned this Sep 4, 2025
@mauri870 mauri870 requested a review from a team as a code owner September 4, 2025 10:30
@mauri870 mauri870 added skip-changelog backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches backport-8.19 Automated backport to the 8.19 branch labels Sep 4, 2025
@mauri870 mauri870 enabled auto-merge (squash) September 4, 2025 11:00
Copy link

@mauri870 mauri870 merged commit b646814 into elastic:main Sep 4, 2025
23 checks passed
Copy link
Contributor

github-actions bot commented Sep 4, 2025

@Mergifyio backport 9.0 9.1

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

cc @mauri870

Copy link
Contributor

mergify bot commented Sep 4, 2025

backport 9.0 9.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 4, 2025
(cherry picked from commit b646814)

# Conflicts:
#	internal/pkg/agent/application/upgrade/upgrade.go
mergify bot pushed a commit that referenced this pull request Sep 4, 2025
mergify bot pushed a commit that referenced this pull request Sep 4, 2025
kaanyalti pushed a commit to kaanyalti/elastic-agent that referenced this pull request Sep 4, 2025
mauri870 added a commit that referenced this pull request Sep 4, 2025
(cherry picked from commit b646814)

Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
mauri870 added a commit that referenced this pull request Sep 4, 2025
(cherry picked from commit b646814)

Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
mauri870 added a commit that referenced this pull request Sep 4, 2025
…tyle calls (#9741)

* chore: fix formatting issues in logp printf-style calls (#9732)

(cherry picked from commit b646814)

# Conflicts:
#	internal/pkg/agent/application/upgrade/upgrade.go

* remove change not in 8.19

---------

Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Rohit-code14 pushed a commit to Rohit-code14/elastic-agent that referenced this pull request Sep 5, 2025
intxgo pushed a commit to intxgo/elastic-agent that referenced this pull request Sep 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.19 Automated backport to the 8.19 branch backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants