[8.19] (backport #9732) chore: fix formatting issues in logp printf-style calls

[mergify]

Proposed commit message

This PR fixes fatal go vet errors on calls to logp functions. Release v0.22.1 of elastic-agent-libs enabled proper go vet support for printf style calls in logp, and that uncovered many misuses of printing directives.

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test

$ go get -u github.com/elastic/[email protected]
$ go vet ./...

Related issues

• Relates logp: enable go vet checks for printf directives elastic-agent-libs#340.
• Relates chore: fix formatting issues in logp printf-style calls beats#45944

  ---

  This is an automatic backport of pull request chore: fix formatting issues in logp printf-style calls #9732 done by Mergify.

[mergify]

Cherry-pick of b646814 has failed:

On branch mergify/bp/8.19/pr-9732
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit b646814d6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   internal/pkg/agent/application/actions/handlers/handler_action_policy_reassign.go
	modified:   internal/pkg/agent/application/upgrade/artifact/download/http/verify_backoff_rtt.go
	modified:   internal/pkg/agent/migration/migrate_config.go
	modified:   internal/pkg/composable/providers/kubernetes/kubernetes.go
	modified:   internal/pkg/config/loader.go
	modified:   internal/pkg/remote/client.go
	modified:   pkg/testing/ess/serverless_provisioner.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   internal/pkg/agent/application/upgrade/upgrade.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

[elastic-sonarqube]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
36.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[elasticmachine]

💚 Build Succeeded

• Buildkite Build
• Commit: 9c78766

History

• 💔 Build #26188 failed c108c04

cc @mauri870