[mongodbatlasreceiver] Add baseURL config #39345
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-collector-contrib into feat--Add-support-for-atlasgov
|
|
|
Please add a changelog by typing |
edmocosta
reviewed
Apr 14, 2025
There was a problem hiding this comment.
Thanks for your contribution, @ArturSantosTD. I've left a few suggestions for your consideration.
VihasMakwana
approved these changes
Apr 16, 2025
schmikei
suggested changes
Apr 16, 2025
There was a problem hiding this comment.
Thanks for the contribution!
My biggest suggestion is making baseURL defined as a default parameter rather than optional.
Please also apply @edmocosta's suggestions on error handling in tests.
…-collector-contrib into feat--Add-support-for-atlasgov
schmikei
suggested changes
Apr 22, 2025
|
@schmikei please take another look when you get the chance so we can proceed with this one. |
schmikei
approved these changes
May 1, 2025
edmocosta
approved these changes
May 5, 2025
edmocosta
added
ready to merge
edmocosta
changed the title
atoulme
approved these changes
May 5, 2025
Merged
mx-psi
added a commit
that referenced
this pull request
May 6, 2025
- **[receiver/prometheus] Upgrade receiver.prometheus.removeLegacyResourceAttributes feature flag (#39803)** - **Feature/update library versions (#39848)** - **metricstarttimeprocessor: Implementation of the subtractinitial strategy (#38594)** - **[mongodbatlasreceiver] Add baseURL config (#39345)** - **[receiver/splunkenterprise] Unexport InfoEntry and InfoContent (#39830)** - **[pkg/ottl] Add support for HasPrefix and HasSuffix (#39825)** - **[receiver/snowflakereceiver] fix(security): CVE-2025-46327 : Upgraded gosnowflake to v1.13.3 (#39862)** - **[pkg/winperfcounters] Add support to retrieve raw values (#39835)** - **Update All github.com/aws packages (#39867)** - **use a single version** <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Ridwan Sharif <[email protected]> Signed-off-by: Bogdan Drutu <[email protected]> Co-authored-by: Curtis Robert <[email protected]> Co-authored-by: Ramachandran A G <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Ridwan Sharif <[email protected]> Co-authored-by: Artur Santos <[email protected]> Co-authored-by: Christos Markou <[email protected]> Co-authored-by: Edmo Vamerlatti Costa <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Bogdan Drutu <[email protected]> Co-authored-by: Paulo Janotti <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]>
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 6, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adding a feature - On mongodbatlas receiver, allow the use of cloud.mongodbgov.com instead of only the default cloud.mongodb.com, adding a new config <!--Describe the documentation added.--> #### Documentation Update mongodbatlas documentation to reflect new config setting <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Christos Markou <[email protected]> Co-authored-by: Edmo Vamerlatti Costa <[email protected]>
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 20, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adding a feature - On mongodbatlas receiver, allow the use of cloud.mongodbgov.com instead of only the default cloud.mongodb.com, adding a new config <!--Describe the documentation added.--> #### Documentation Update mongodbatlas documentation to reflect new config setting <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Christos Markou <[email protected]> Co-authored-by: Edmo Vamerlatti Costa <[email protected]>
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description Adding a feature - On mongodbatlas receiver, allow the use of cloud.mongodbgov.com instead of only the default cloud.mongodb.com, adding a new config <!--Describe the documentation added.--> #### Documentation Update mongodbatlas documentation to reflect new config setting <!--Please delete paragraphs that you did not use before submitting.--> --------- Co-authored-by: Christos Markou <[email protected]> Co-authored-by: Edmo Vamerlatti Costa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a feature - On mongodbatlas receiver, allow the use of cloud.mongodbgov.com instead of only the default cloud.mongodb.com, adding a new config
Documentation
Update mongodbatlas documentation to reflect new config setting