updat tests

Author: ArturSantosTD

receiver/mongodbatlasreceiver/config.go

@@ -11,7 +11,6 @@ import (
 	"strings"
 	"time"
 
-	"go.mongodb.org/atlas/mongodbatlas"
 	"go.opentelemetry.io/collector/component"
 	"go.opentelemetry.io/collector/config/configopaque"
 	"go.opentelemetry.io/collector/config/configretry"
@@ -140,10 +139,6 @@ var (
 func (c *Config) Validate() error {
 	var errs error
 
-	if c.BaseURL == "" {
-		c.BaseURL = mongodbatlas.CloudURL
-	}
-
 	if err := validateEndpoint(c.BaseURL); err != nil {
 		return fmt.Errorf("invalid base_url %q: %w", c.BaseURL, err)
 	}

receiver/mongodbatlasreceiver/config_test.go

@@ -9,6 +9,7 @@ import (
 	"time"
 
 	"github.com/stretchr/testify/require"
+	"go.mongodb.org/atlas/mongodbatlas"
 	"go.opentelemetry.io/collector/component"
 	"go.opentelemetry.io/collector/config/configtls"
 	"go.opentelemetry.io/collector/confmap/confmaptest"
@@ -28,12 +29,14 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Empty config",
 			input: Config{
+				BaseURL:          mongodbatlas.CloudURL,
 				ControllerConfig: scraperhelper.NewDefaultControllerConfig(),
 			},
 		},
 		{
 			name: "Valid alerts config",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Alerts: AlertConfig{
 					Enabled:  true,
 					Endpoint: "0.0.0.0:7706",
@@ -46,6 +49,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Alerts missing endpoint",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Alerts: AlertConfig{
 					Enabled: true,
 					Secret:  "some_secret",
@@ -58,6 +62,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Alerts missing secret",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Alerts: AlertConfig{
 					Enabled:  true,
 					Endpoint: "0.0.0.0:7706",
@@ -70,6 +75,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Invalid endpoint",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Alerts: AlertConfig{
 					Enabled:  true,
 					Endpoint: "7706",
@@ -83,6 +89,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "TLS config missing key",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Alerts: AlertConfig{
 					Enabled:  true,
 					Endpoint: "0.0.0.0:7706",
@@ -101,6 +108,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "TLS config missing cert",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Alerts: AlertConfig{
 					Enabled:  true,
 					Endpoint: "0.0.0.0:7706",
@@ -119,6 +127,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Valid Metrics Config",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Projects: []*ProjectConfig{
 					{
 						Name: "Project1",
@@ -130,6 +139,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Valid Metrics Config with multiple projects with an inclusion or exclusion",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Projects: []*ProjectConfig{
 					{
 						Name:            "Project1",
@@ -146,6 +156,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "invalid Metrics Config",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Projects: []*ProjectConfig{
 					{
 						Name:            "Project1",
@@ -160,6 +171,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Valid Logs Config",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Logs: LogConfig{
 					Enabled: true,
 					Projects: []*LogsProjectConfig{
@@ -177,6 +189,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Invalid Logs Config",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Logs: LogConfig{
 					Enabled: true,
 				},
@@ -187,6 +200,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Invalid ProjectConfig",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Logs: LogConfig{
 					Enabled: true,
 					Projects: []*LogsProjectConfig{
@@ -207,6 +221,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Invalid Alerts Retrieval ProjectConfig",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Alerts: AlertConfig{
 					Enabled: true,
 					Mode:    alertModePoll,
@@ -226,6 +241,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Invalid Alerts Poll No Projects",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Alerts: AlertConfig{
 					Enabled:  true,
 					Mode:     alertModePoll,
@@ -239,6 +255,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Valid Alerts Config",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Alerts: AlertConfig{
 					Enabled: true,
 					Mode:    alertModePoll,
@@ -255,6 +272,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Invalid Alerts Mode",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Alerts: AlertConfig{
 					Enabled:  true,
 					Mode:     "invalid type",
@@ -267,6 +285,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Invalid Page Size",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Alerts: AlertConfig{
 					Enabled: true,
 					Mode:    alertModePoll,
@@ -284,6 +303,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Invalid events config - no projects",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Events: &EventsConfig{
 					Projects: []*ProjectConfig{},
 				},
@@ -294,6 +314,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Valid Access Logs Config",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Logs: LogConfig{
 					Projects: []*LogsProjectConfig{
 						{
@@ -314,6 +335,7 @@ func TestValidate(t *testing.T) {
 		{
 			name: "Invalid Access Logs Config - bad project config",
 			input: Config{
+				BaseURL: mongodbatlas.CloudURL,
 				Logs: LogConfig{
 					Enabled: true,
 					Projects: []*LogsProjectConfig{