suggested changes

Author: ArturSantosTD

receiver/mongodbatlasreceiver/README.md

@@ -34,7 +34,7 @@ In order to collect access logs, the requesting API key needs the appropriate pe
 
 MongoDB Atlas [Documentation](https://www.mongodb.com/docs/atlas/reference/api/logs/#logs) recommends a polling interval of 5 minutes.
 
-- `base_url` (optional) set the base URL to connect to to Atlas Cloud
+- `base_url` (default https://cloud.mongodb.com/) set the base URL to connect to to Atlas Cloud
 - `public_key` (required for metrics, logs, or alerts in `poll` mode)
 - `private_key` (required for metrics, logs, or alerts in `poll` mode)
 - `granularity` (default `PT1M` - See [MongoDB Atlas Documentation](https://docs.atlas.mongodb.com/reference/api/process-measurements/))

receiver/mongodbatlasreceiver/access_logs_test.go

@@ -278,9 +278,7 @@ func TestAccessLogsRetrieval(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			logSink := &consumertest.LogsSink{}
 			rcvr, e := newAccessLogsReceiver(receivertest.NewNopSettings(metadata.Type), tc.config(), logSink)
-			if e != nil {
-				t.Fatalf("failed to create receiver: %v", e)
-			}
+			require.NoError(t, e)
 			tc.setup(rcvr)
 
 			err := rcvr.Start(context.Background(), componenttest.NewNopHost(), storage.NewNopClient())
@@ -318,9 +316,7 @@ func TestCheckpointing(t *testing.T) {
 
 	logSink := &consumertest.LogsSink{}
 	rcvr, e := newAccessLogsReceiver(receivertest.NewNopSettings(metadata.Type), config, logSink)
-	if e != nil {
-		t.Fatalf("failed to create receiver: %v", e)
-	}
+	require.NoError(t, e)
 	rcvr.client = simpleAccessLogClient()
 
 	// First cluster checkpoint should be nil

receiver/mongodbatlasreceiver/config.go

@@ -7,6 +7,7 @@ import (
 	"errors"
 	"fmt"
 	"net"
+	"net/url"
 	"strings"
 	"time"
 
@@ -134,6 +135,16 @@ var (
 
 func (c *Config) Validate() error {
 	var errs error
+	baseurl := c.BaseURL
+	if u, err := url.ParseRequestURI(baseurl); err != nil {
+		errs = multierr.Append(errs, fmt.Errorf("base_url is not valid: %w", err))
+		if u.Scheme == "" {
+			errs = multierr.Append(errs, fmt.Errorf("base_url must contain a scheme (http or https)"))
+		}
+		if u.Host == "" {
+			errs = multierr.Append(errs, fmt.Errorf("base_url must contain a host"))
+		}
+	}
 
 	for _, project := range c.Projects {
 		if len(project.ExcludeClusters) != 0 && len(project.IncludeClusters) != 0 {

receiver/mongodbatlasreceiver/config_test.go

@@ -361,6 +361,7 @@ func TestLoadConfig(t *testing.T) {
 
 	expected := factory.CreateDefaultConfig().(*Config)
 	expected.MetricsBuilderConfig = metadata.DefaultMetricsBuilderConfig()
+	expected.BaseURL = "https://cloud.mongodb.com"
 	expected.PrivateKey = "my-private-key"
 	expected.PublicKey = "my-public-key"
 	expected.Logs = LogConfig{

receiver/mongodbatlasreceiver/events_test.go

@@ -54,9 +54,7 @@ func TestStartAndShutdown(t *testing.T) {
 		t.Run(tc.desc, func(t *testing.T) {
 			sink := &consumertest.LogsSink{}
 			r, e := newEventsReceiver(receivertest.NewNopSettings(metadata.Type), tc.getConfig(), sink)
-			if e != nil {
-				t.Fatalf("failed to create receiver: %v", e)
-			}
+			require.NoError(t, e)
 			err := r.Start(context.Background(), componenttest.NewNopHost(), storage.NewNopClient())
 			if tc.expectedStartErr != nil {
 				require.ErrorContains(t, err, tc.expectedStartErr.Error())
@@ -123,9 +121,7 @@ func TestPoll(t *testing.T) {
 
 	sink := &consumertest.LogsSink{}
 	r, e := newEventsReceiver(receivertest.NewNopSettings(metadata.Type), cfg, sink)
-	if e != nil {
-		t.Fatalf("failed to create receiver: %v", e)
-	}
+	require.NoError(t, e)
 	mClient := &mockEventsClient{}
 	mClient.setupMock(t)
 	r.client = mClient
@@ -171,9 +167,7 @@ func TestProjectGetFailure(t *testing.T) {
 
 	sink := &consumertest.LogsSink{}
 	r, e := newEventsReceiver(receivertest.NewNopSettings(metadata.Type), cfg, sink)
-	if e != nil {
-		t.Fatalf("failed to create receiver: %v", e)
-	}
+	require.NoError(t, e)
 	mClient := &mockEventsClient{}
 	mClient.On("GetProject", mock.Anything, "fake-project").Return(nil, fmt.Errorf("unable to get project: %d", http.StatusUnauthorized))
 	mClient.On("GetOrganization", mock.Anything, "fake-org").Return(nil, fmt.Errorf("unable to get org: %d", http.StatusUnauthorized))

receiver/mongodbatlasreceiver/factory.go

@@ -9,6 +9,7 @@ import (
 	"fmt"
 	"time"
 
+	"go.mongodb.org/atlas/mongodbatlas"
 	"go.opentelemetry.io/collector/component"
 	"go.opentelemetry.io/collector/config/configretry"
 	"go.opentelemetry.io/collector/consumer"
@@ -106,6 +107,7 @@ func createCombinedLogReceiver(
 
 func createDefaultConfig() component.Config {
 	c := &Config{
+		BaseURL:              mongodbatlas.CloudURL,
 		ControllerConfig:     scraperhelper.NewDefaultControllerConfig(),
 		Granularity:          defaultGranularity,
 		BackOffConfig:        configretry.NewDefaultBackOffConfig(),

receiver/mongodbatlasreceiver/internal/mongodb_atlas_client.go

@@ -147,8 +147,7 @@ func NewMongoDBAtlasClient(
 
 	client, err := mongodbatlas.New(tc, mongodbatlas.SetBaseURL(baseURL))
 	if err != nil {
-		log.Error("Failed to create client", zap.Error(err))
-		return nil, fmt.Errorf("failed to create MongoDB Atlas client: %w", err) // Return nil and the error
+		return nil, fmt.Errorf("failed to create MongoDB Atlas client: %w", err)
 	}
 
 	return &MongoDBAtlasClient{