requested changes

Author: ArturSantosTD

.chloggen/feat--Add-support-for-atlasgov.yaml

@@ -7,7 +7,7 @@ change_type: enhancement
 component: mongodbatlasreceiver
 
 # A brief description of the change.  Surround your text with quotes ("") if it needs to start with a backtick (`).
-note: "Add support for AtlasGov"
+note: "Add support for setting custom base URL for the MongoDB Atlas API"
 
 # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists.
 issues: [39345]
@@ -24,4 +24,4 @@ subtext:
 # Include 'user' if the change is relevant to end users.
 # Include 'api' if there is a change to a library API.
 # Default: '[user]'
-change_logs: [api]
+change_logs: [user]

receiver/mongodbatlasreceiver/README.md

@@ -34,7 +34,7 @@ In order to collect access logs, the requesting API key needs the appropriate pe
 
 MongoDB Atlas [Documentation](https://www.mongodb.com/docs/atlas/reference/api/logs/#logs) recommends a polling interval of 5 minutes.
 
-- `base_url` (optional) set to https://cloud.mongodbgov.com to connecto to Atlas Gov
+- `base_url` (optional) set the base URL to connect to to Atlas Cloud
 - `public_key` (required for metrics, logs, or alerts in `poll` mode)
 - `private_key` (required for metrics, logs, or alerts in `poll` mode)
 - `granularity` (default `PT1M` - See [MongoDB Atlas Documentation](https://docs.atlas.mongodb.com/reference/api/process-measurements/))

receiver/mongodbatlasreceiver/internal/mongodb_atlas_client.go

@@ -9,6 +9,7 @@ import (
 	"errors"
 	"fmt"
 	"net/http"
+	"net/url"
 	"strconv"
 	"sync"
 	"time"
@@ -142,15 +143,32 @@ func NewMongoDBAtlasClient(
 	tc := &http.Client{Transport: roundTripper}
 
 	if baseURL == "" {
-		baseURL = "https://cloud.mongodb.com"
+		baseURL = mongodbatlas.CloudURL
 	}
 
-	log.Debug("Creating MongoDB Atlas client",
-		zap.String("baseURL", baseURL))
+	if !isValidURL(baseURL) {
+		log.Error("Invalid baseURL provided, using default:", zap.String("providedURL", baseURL), zap.String("defaultURL", mongodbatlas.CloudURL))
+		baseURL = mongodbatlas.CloudURL // Fallback to the default if invalid
+	}
 
 	client, err := mongodbatlas.New(tc, mongodbatlas.SetBaseURL(baseURL))
 	if err != nil {
-		log.Info("failed to create client", zap.Error(err))
+		log.Error("Failed to create client", zap.Error(err))
+	}
+
+	log.Info("Testing MongoDB Atlas API connection",
+		zap.String("baseURL", baseURL))
+
+	// Test the connection by making a simple API call (list organizations)
+	_, _, err = client.Organizations.List(context.Background(), &mongodbatlas.OrganizationsListOptions{})
+	if err != nil {
+		log.Error("Failed to connect to MongoDB Atlas API. Possible invalid base URL or credentials:",
+			zap.String("baseURL", baseURL),
+			zap.Error(err), // Include the underlying error for more details
+		)
+	} else {
+		log.Info("Successfully connected to MongoDB Atlas API",
+			zap.String("baseURL", baseURL))
 	}
 
 	return &MongoDBAtlasClient{
@@ -161,6 +179,18 @@ func NewMongoDBAtlasClient(
 	}
 }
 
+// isValidURL checks if a string is a valid URL.
+func isValidURL(str string) bool {
+	u, err := url.ParseRequestURI(str)
+	if err != nil {
+		return false
+	}
+	if u.Scheme == "" || u.Host == "" {
+		return false
+	}
+	return true
+}
+
 func (s *MongoDBAtlasClient) Shutdown() error {
 	s.transport.CloseIdleConnections()
 	return s.roundTripper.Shutdown()