Skip to content

[receiver/splunkenterprise] Unexport InfoEntry and InfoContent #39830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented May 2, 2025

this struct has no reason to be exported.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be captured as a breaking change in the changelog?

@atoulme atoulme force-pushed the unexport_struct branch from e0fd8aa to 40419c5 Compare May 2, 2025 19:24
@atoulme atoulme changed the title [chore]unexport struct [receiver/splunkenterprise] Unexport InfoEntry and InfoContent May 2, 2025
@atoulme
Copy link
Contributor Author

atoulme commented May 2, 2025

Should this be captured as a breaking change in the changelog?

Added changelog

@codeboten codeboten merged commit 26dd5a6 into open-telemetry:main May 5, 2025
174 checks passed
@github-actions github-actions bot added this to the next release milestone May 5, 2025
@atoulme atoulme deleted the unexport_struct branch May 5, 2025 18:22
@mx-psi mx-psi mentioned this pull request May 6, 2025
mx-psi added a commit that referenced this pull request May 6, 2025
- **[receiver/prometheus] Upgrade
receiver.prometheus.removeLegacyResourceAttributes feature flag
(#39803)**
- **Feature/update library versions (#39848)**
- **metricstarttimeprocessor: Implementation of the subtractinitial
strategy (#38594)**
- **[mongodbatlasreceiver] Add baseURL config (#39345)**
- **[receiver/splunkenterprise] Unexport InfoEntry and InfoContent
(#39830)**
- **[pkg/ottl] Add support for HasPrefix and HasSuffix (#39825)**
- **[receiver/snowflakereceiver] fix(security): CVE-2025-46327 :
Upgraded gosnowflake to v1.13.3 (#39862)**
- **[pkg/winperfcounters] Add support to retrieve raw values (#39835)**
- **Update All github.com/aws packages (#39867)**
- **use a single version**

<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
#### Description

<!-- Issue number (e.g. #1234) or full URL to issue, if applicable. -->
#### Link to tracking issue
Fixes

<!--Describe what testing was performed and which tests were added.-->
#### Testing

<!--Describe the documentation added.-->
#### Documentation

<!--Please delete paragraphs that you did not use before submitting.-->

---------

Signed-off-by: Ridwan Sharif <[email protected]>
Signed-off-by: Bogdan Drutu <[email protected]>
Co-authored-by: Curtis Robert <[email protected]>
Co-authored-by: Ramachandran A G <[email protected]>
Co-authored-by: Antoine Toulme <[email protected]>
Co-authored-by: Ridwan Sharif <[email protected]>
Co-authored-by: Artur Santos <[email protected]>
Co-authored-by: Christos Markou <[email protected]>
Co-authored-by: Edmo Vamerlatti Costa <[email protected]>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Bogdan Drutu <[email protected]>
Co-authored-by: Paulo Janotti <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <[email protected]>
vincentfree pushed a commit to ing-bank/opentelemetry-collector-contrib that referenced this pull request May 6, 2025
…telemetry#39830)

this struct has no reason to be exported.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vincentfree pushed a commit to ing-bank/opentelemetry-collector-contrib that referenced this pull request May 20, 2025
…telemetry#39830)

this struct has no reason to be exported.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
songy23 pushed a commit that referenced this pull request May 22, 2025
Adds a new check on checkapi that prevents the unkeyed initialization of
literals. Unkeyed initialization breaks if the API exposed by the struct
fields changes. Adding an anonymous _ struct{} field ensures all
developers must use a named initialization.

This is explained in more detail in
open-telemetry/opentelemetry-collector#12360

This PR needs #39830 and #39831 merged first.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dragonlord93 pushed a commit to dragonlord93/opentelemetry-collector-contrib that referenced this pull request May 23, 2025
…telemetry#39830)

this struct has no reason to be exported.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dragonlord93 pushed a commit to dragonlord93/opentelemetry-collector-contrib that referenced this pull request May 23, 2025
…ry#39832)

Adds a new check on checkapi that prevents the unkeyed initialization of
literals. Unkeyed initialization breaks if the API exposed by the struct
fields changes. Adding an anonymous _ struct{} field ensures all
developers must use a named initialization.

This is explained in more detail in
open-telemetry/opentelemetry-collector#12360

This PR needs open-telemetry#39830 and open-telemetry#39831 merged first.

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants