[receiver/fluentforward] move struct to internal, do not expose in API #39831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codeboten
reviewed
May 2, 2025
atoulme
force-pushed
the
move_ack_to_internal
branch
from
d8d6692 to
c4e8611
Compare
I think this will bring more attention than is warranted to this change, but I guess we can. |
atoulme
force-pushed
the
move_ack_to_internal
branch
from
c4e8611 to
80fe570
Compare
atoulme
changed the title
|
added a changelog. |
atoulme
force-pushed
the
move_ack_to_internal
branch
from
80fe570 to
3df6c8b
Compare
dmitryax
approved these changes
May 2, 2025
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 6, 2025
open-telemetry#39831) This struct is internal to the receiver and not exposed as part of Config. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 20, 2025
open-telemetry#39831) This struct is internal to the receiver and not exposed as part of Config. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
songy23
pushed a commit
that referenced
this pull request
May 22, 2025
Adds a new check on checkapi that prevents the unkeyed initialization of
literals. Unkeyed initialization breaks if the API exposed by the struct
fields changes. Adding an anonymous _ struct{} field ensures all
developers must use a named initialization.
This is explained in more detail in
open-telemetry/opentelemetry-collector#12360
This PR needs #39830 and #39831 merged first.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
open-telemetry#39831) This struct is internal to the receiver and not exposed as part of Config. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
…ry#39832) Adds a new check on checkapi that prevents the unkeyed initialization of literals. Unkeyed initialization breaks if the API exposed by the struct fields changes. Adding an anonymous _ struct{} field ensures all developers must use a named initialization. This is explained in more detail in open-telemetry/opentelemetry-collector#12360 This PR needs open-telemetry#39830 and open-telemetry#39831 merged first. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This struct is internal to the receiver and not exposed as part of Config.