[pkg/winperfcounters] Add support to retrieve raw values #39835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com:pjanotti/opentelemetry-service-contrib into pkg-winperfcounters-add-raw-counters-support
github-actions
bot
added
receiver/windowsperfcounters
receiver/sqlserver
receiver/iis
receiver/activedirectoryds
Run Windows
alxbl
approved these changes
May 5, 2025
atoulme
reviewed
May 5, 2025
atoulme
approved these changes
May 5, 2025
Merged
mx-psi
added a commit
that referenced
this pull request
May 6, 2025
- **[receiver/prometheus] Upgrade receiver.prometheus.removeLegacyResourceAttributes feature flag (#39803)** - **Feature/update library versions (#39848)** - **metricstarttimeprocessor: Implementation of the subtractinitial strategy (#38594)** - **[mongodbatlasreceiver] Add baseURL config (#39345)** - **[receiver/splunkenterprise] Unexport InfoEntry and InfoContent (#39830)** - **[pkg/ottl] Add support for HasPrefix and HasSuffix (#39825)** - **[receiver/snowflakereceiver] fix(security): CVE-2025-46327 : Upgraded gosnowflake to v1.13.3 (#39862)** - **[pkg/winperfcounters] Add support to retrieve raw values (#39835)** - **Update All github.com/aws packages (#39867)** - **use a single version** <!--Ex. Fixing a bug - Describe the bug and how this fixes the issue. Ex. Adding a feature - Explain what this achieves.--> #### Description <!-- Issue number (e.g. #1234) or full URL to issue, if applicable. --> #### Link to tracking issue Fixes <!--Describe what testing was performed and which tests were added.--> #### Testing <!--Describe the documentation added.--> #### Documentation <!--Please delete paragraphs that you did not use before submitting.--> --------- Signed-off-by: Ridwan Sharif <[email protected]> Signed-off-by: Bogdan Drutu <[email protected]> Co-authored-by: Curtis Robert <[email protected]> Co-authored-by: Ramachandran A G <[email protected]> Co-authored-by: Antoine Toulme <[email protected]> Co-authored-by: Ridwan Sharif <[email protected]> Co-authored-by: Artur Santos <[email protected]> Co-authored-by: Christos Markou <[email protected]> Co-authored-by: Edmo Vamerlatti Costa <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Bogdan Drutu <[email protected]> Co-authored-by: Paulo Janotti <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <[email protected]>
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 6, 2025
…try#39835) Adding public methods that allow to retrieve the raw values of Windows performance counters. This is needed to allow removal of the vendored code under `receiver/hostmetricsreceiver/internal/perfcounters/` used only by that component. This vendored code retrieves raw values of counters instead of calculated ones, e.g.: it doesn't retrieve rate, but the actual values used to calculate the rate of a counter. See open-telemetry#38858 (comment) for details.
atoulme
pushed a commit
that referenced
this pull request
May 9, 2025
…ers (#39916) Completes the migration to `pkg/winperfcounters` and removes the vendored third party package, see #38858 (comment) for details.. Previous related changes: - #39690 - #39835 Fixes #38858 Memory and CPU usage by the collector went collect these metrics were not affected by this change, verified manually running the collector on Windows.
vincentfree
pushed a commit
to ing-bank/opentelemetry-collector-contrib
that referenced
this pull request
May 20, 2025
…try#39835) Adding public methods that allow to retrieve the raw values of Windows performance counters. This is needed to allow removal of the vendored code under `receiver/hostmetricsreceiver/internal/perfcounters/` used only by that component. This vendored code retrieves raw values of counters instead of calculated ones, e.g.: it doesn't retrieve rate, but the actual values used to calculate the rate of a counter. See open-telemetry#38858 (comment) for details.
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
…try#39835) Adding public methods that allow to retrieve the raw values of Windows performance counters. This is needed to allow removal of the vendored code under `receiver/hostmetricsreceiver/internal/perfcounters/` used only by that component. This vendored code retrieves raw values of counters instead of calculated ones, e.g.: it doesn't retrieve rate, but the actual values used to calculate the rate of a counter. See open-telemetry#38858 (comment) for details.
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
…ers (open-telemetry#39916) Completes the migration to `pkg/winperfcounters` and removes the vendored third party package, see open-telemetry#38858 (comment) for details.. Previous related changes: - open-telemetry#39690 - open-telemetry#39835 Fixes open-telemetry#38858 Memory and CPU usage by the collector went collect these metrics were not affected by this change, verified manually running the collector on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding public methods that allow to retrieve the raw values of Windows performance counters. This is needed to allow removal of the vendored code under
receiver/hostmetricsreceiver/internal/perfcounters/used only by that component. This vendored code retrieves raw values of counters instead of calculated ones, e.g.: it doesn't retrieve rate, but the actual values used to calculate the rate of a counter. See #38858 (comment) for details.