[receiver/hostmetrics] Migrate from vendored code to pkg/winperfcounters #39916
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
reviewed
May 6, 2025
receiver/hostmetricsreceiver/internal/scraper/loadscraper/load_scraper_windows.go
Show resolved
Hide resolved
github-actions
bot
requested review from
ankitpatel96,
dineshg13,
IbraheemA,
jade-guiton-dd,
liustanley and
mackjmr
braydonk
approved these changes
May 9, 2025
|
Noticed this doesn't have a changelog. Conflicted on whether it needs one, but I'm inclined to say it might be a good idea. Shouldn't provide any user-visible changes, but might be good for tracking on the off-chance there's an adverse behaviour from this change that someone is trying to track down? |
…github.com:pjanotti/opentelemetry-service-contrib into migrate-hostmetricsreceiver-to-pkg-winperfcounters
atoulme
approved these changes
May 9, 2025
dragonlord93
pushed a commit
to dragonlord93/opentelemetry-collector-contrib
that referenced
this pull request
May 23, 2025
…ers (open-telemetry#39916) Completes the migration to `pkg/winperfcounters` and removes the vendored third party package, see open-telemetry#38858 (comment) for details.. Previous related changes: - open-telemetry#39690 - open-telemetry#39835 Fixes open-telemetry#38858 Memory and CPU usage by the collector went collect these metrics were not affected by this change, verified manually running the collector on Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes the migration to
pkg/winperfcountersand removes the vendored third party package, see #38858 (comment) for details.. Previous related changes:Fixes #38858
Memory and CPU usage by the collector went collect these metrics were not affected by this change, verified manually running the collector on Windows.