chore: upgrade react-popper #3157
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmfrancois
commented
Jan 11, 2021
yarn.lock
Outdated
| dependencies: | ||
| react-fast-compare "^3.0.1" | ||
| warning "^4.0.2" | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
react-popper 1 still exist but only for storybook a11y dependency which is only for dev
Collaborator
1 similar comment
Collaborator
jmfrancois
commented
Jan 11, 2021
output/components.eslint.txt
Outdated
| 347:2 error defaultProp "minimumPercentage" has no corresponding propTypes declaration react/default-props-match-prop-types | ||
| 348:2 error defaultProp "display" has no corresponding propTypes declaration react/default-props-match-prop-types | ||
|
|
||
| /home/travis/build/Talend/ui/packages/components/src/QualityBar/QualityBar.component.js |
Collaborator
Author
frassinier
approved these changes
Jan 11, 2021
Collaborator
Contributor
There was a problem hiding this comment.
There are visual regressions
- in Typeahead: width doesn't fit input at min, and max height is way smaller
- in form > multiSelectTag: max height is smaller
I think, fixing the first one should fix the second one (and all the components that rely on Typeahead like Datalist)
mhuchet
approved these changes
Jan 11, 2021
Collaborator
1 similar comment
Collaborator
but still do not work
Collaborator
1 similar comment
Collaborator
Collaborator
Collaborator
Collaborator
1 similar comment
Collaborator
Collaborator
Collaborator
Collaborator
Author
|
super seed by #3176 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
we are on react-popper v1 which depends on deprecated popper.js dependency.
the future design system rely on @popperjs/core.
Usage of popper today in TUI:
What is the chosen solution to this problem?
We have to choose between:
Please check if the PR fulfills these requirements
[ ] This PR introduces a breaking change