feat(components): tags #3164

frassinier · 2021-01-15T10:20:30Z

What is the problem this PR is trying to solve?
Tags come from Bootstrap and it's time to get rid of Bootstrap

What is the chosen solution to this problem?
Tags come from the Design System

Please check if the PR fulfills these requirements

The PR commit message follows our guidelines
Tests for the changes have been added (for bug fixes / features) And non reg done before need review
Docs have been added / updated (for bug fixes / features)
Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

build-travis-ci · 2021-01-18T21:28:02Z

Demo is available here

build-travis-ci · 2021-01-18T21:38:19Z

Demo is available here

build-travis-ci · 2021-01-19T13:51:21Z

Demo is available here

build-travis-ci · 2021-01-19T14:44:14Z

Demo is available here

jmfrancois · 2021-01-19T17:06:18Z

packages/components/package.json

    "url": "https://github.com/Talend/ui.git"
  },
  "dependencies": {
+    "@talend/design-system": "^1.0.0-beta.12",


beta do not work with CDN, you should do a first stable release first

jmfrancois · 2021-01-19T17:06:44Z

yarn.lock

  dependencies:
    "@types/node" ">= 8"

+"@popperjs/core@^2.5.4":


what about react-popper migration first ?
So it means we have to finish and merge #3157 first right ?

build-travis-ci · 2021-01-21T14:40:36Z

Demo is available here

jmfrancois · 2021-01-21T16:31:56Z

packages/components/package.json

    "@storybook/addons": "^5.3.1",
    "@storybook/react": "^5.3.1",
    "@talend/bootstrap-theme": "^6.9.0",
+    "@talend/design-system": "^1.0.2",


it s already a dep

build-travis-ci · 2021-01-21T22:38:23Z

Demo is available here

build-travis-ci · 2021-01-21T23:40:53Z

Demo is available here

# Conflicts: # packages/components/package.json # yarn.lock

github-actions · 2021-02-17T17:26:08Z

Size Change: +1.3 kB (0%)

Total Size: 2.3 MB

Filename	Size	Change
`./packages/components/dist/TalendReactComponents.css`	33.8 kB	+27 B (0%)
`./packages/components/dist/TalendReactComponents.js`	501 kB	+577 B (0%)
`./packages/components/dist/TalendReactComponents.js.dependencies.json`	874 B	+63 B (+8%)	🔍
`./packages/components/dist/TalendReactComponents.min.js`	242 kB	+186 B (0%)
`./packages/components/dist/TalendReactComponents.min.js.dependencies.json`	869 B	+58 B (+7%)	🔍
`./packages/containers/dist/TalendReactContainers.js.dependencies.json`	1.16 kB	+47 B (+4%)
`./packages/containers/dist/TalendReactContainers.min.js.dependencies.json`	1.17 kB	+45 B (+4%)
`./packages/datagrid/dist/TalendReactDatagrid.js.dependencies.json`	965 B	+50 B (+5%)	🔍
`./packages/datagrid/dist/TalendReactDatagrid.min.js.dependencies.json`	967 B	+51 B (+6%)	🔍
`./packages/forms/dist/TalendReactForms.js.dependencies.json`	1.02 kB	+46 B (+5%)	🔍
`./packages/forms/dist/TalendReactForms.min.js.dependencies.json`	1.03 kB	+52 B (+5%)	🔍
`./packages/stepper/dist/TalendReactStepper.js.dependencies.json`	960 B	+48 B (+5%)	🔍
`./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json`	966 B	+51 B (+6%)	🔍

ℹ️ View Unchanged

Filename	Size	Change
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js`	6.37 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json`	259 B	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js`	2.56 kB	0 B
`./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json`	263 B	0 B
`./packages/cmf/dist/TalendReactCmf.js`	93.6 kB	0 B
`./packages/cmf/dist/TalendReactCmf.js.dependencies.json`	423 B	0 B
`./packages/cmf/dist/TalendReactCmf.min.js`	31.5 kB	0 B
`./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json`	423 B	0 B
`./packages/containers/dist/TalendReactContainers.css`	533 B	0 B
`./packages/containers/dist/TalendReactContainers.js`	59.5 kB	0 B
`./packages/containers/dist/TalendReactContainers.min.js`	25.4 kB	0 B
`./packages/datagrid/dist/TalendReactDatagrid.css`	8.95 kB	0 B
`./packages/datagrid/dist/TalendReactDatagrid.js`	58.9 kB	0 B
`./packages/datagrid/dist/TalendReactDatagrid.min.js`	18.4 kB	0 B
`./packages/forms/dist/TalendReactForms.css`	4.71 kB	0 B
`./packages/forms/dist/TalendReactForms.js`	298 kB	0 B
`./packages/forms/dist/TalendReactForms.min.js`	110 kB	0 B
`./packages/icons/dist/bundle.js`	2.4 kB	0 B
`./packages/icons/dist/info.js`	1.95 kB	0 B
`./packages/icons/dist/react.esm.js`	184 kB	0 B
`./packages/icons/dist/react.js`	185 kB	0 B
`./packages/icons/dist/talend-icons-webfont.css`	2.83 kB	0 B
`./packages/icons/dist/talendicons.css`	199 B	0 B
`./packages/icons/dist/TalendIcons.js`	190 kB	0 B
`./packages/icons/dist/TalendIcons.js.dependencies.json`	107 B	0 B
`./packages/icons/dist/TalendIcons.min.js`	187 kB	0 B
`./packages/icons/dist/TalendIcons.min.js.dependencies.json`	107 B	0 B
`./packages/sagas/dist/TalendReactSagas.js`	2.5 kB	0 B
`./packages/sagas/dist/TalendReactSagas.js.dependencies.json`	259 B	0 B
`./packages/sagas/dist/TalendReactSagas.min.js`	924 B	0 B
`./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json`	263 B	0 B
`./packages/stepper/dist/TalendReactStepper.js`	4.83 kB	0 B
`./packages/stepper/dist/TalendReactStepper.min.js`	1.83 kB	0 B
`./packages/theme/dist/bootstrap.css`	32.5 kB	0 B
`./packages/theme/dist/bootstrap.js`	569 B	0 B

_{compressed-size-action}

build-travis-ci · 2021-02-18T21:32:41Z

Demo is available here

build-travis-ci · 2021-02-18T21:39:06Z

Demo is available here

build-travis-ci · 2021-02-18T21:56:35Z

Demo is available here

build-travis-ci · 2021-02-18T22:20:04Z

Demo is available here

build-travis-ci · 2021-02-19T17:36:55Z

Demo is available here

build-travis-ci · 2021-02-19T17:50:04Z

Demo is available here

build-travis-ci · 2021-02-19T17:50:38Z

Demo is available here

build-travis-ci · 2021-02-19T17:59:00Z

Demo is available here

packages/components/__mocks__/@talend/design-system.js

packages/components/src/Tag/Tag.component.js

jmfrancois · 2021-02-24T09:42:31Z

yarn.lock

+  version "2.7.0"
+  resolved "https://registry.yarnpkg.com/@popperjs/core/-/core-2.7.0.tgz#5f7760965170f7f1e2910d2498c5be88b47a2a8c"
+  integrity sha512-V3WyEc8ZyAuOQ2fpFuTuYYOd2tV4NePeSdxaHYgYAOs7ERLxlcFi2XsmgI5LJFdAUmJKXsg8jaIiVTkTHQygQw==
+


please take care to remove this lib.
I think a simple npx yarn-dedup should do the job but I am afraid it increase a lot the changes in the yarn lock :D

build-travis-ci · 2021-02-24T10:06:21Z

Demo is available here

build-travis-ci · 2021-02-24T10:28:43Z

Demo is available here

* feat: tags * feat: tags * feat: tags * feat: tags * feat: tags * chore(ci): prettier * feat: tags * feat: tags * chore(components): migrate react-popper to v2 * Update package.json * feat: tags * feat: tags * upgrade yarn.lock after merge * ds 1.0.7 * Extract Tag as new component * chore(ci): update code style outputs * chore(ci): prettier * revert * revert * proptypes * chore(ci): update code style outputs * unit tests * chore(ci): update code style outputs * chore(ci): prettier * unit tests * chore(ci): update code style outputs * yarn dedupe * chore: dedup Co-authored-by: travis <travis> Co-authored-by: jmfrancois <[email protected]>

feat: tags

ffb7bfe

frassinier added easy review enhancement need review labels Jan 15, 2021

Fabien Rassinier and others added 6 commits January 18, 2021 21:25

feat: tags

00d3977

feat: tags

b963bd3

feat: tags

b32c3ff

Merge branch 'master' into frassinier/feat/tags

00b4659

feat: tags

4e09153

chore(ci): prettier

f3a32f8

feat: tags

823b36c

feat: tags

cb8d8eb

jmfrancois reviewed Jan 19, 2021

View reviewed changes

frassinier marked this pull request as draft January 21, 2021 00:14

chore(components): migrate react-popper to v2

c65539c

jmfrancois reviewed Jan 21, 2021

View reviewed changes

Update package.json

dd69239

feat: tags

c54bc9a

Fabien Rassinier added 3 commits January 22, 2021 11:44

feat: tags

118637e

Merge remote-tracking branch 'origin/master' into frassinier/feat/tags

810544b

# Conflicts: # packages/components/package.json # yarn.lock

upgrade yarn.lock after merge

9c8b9fd

proptypes

9e9eefd

chore(ci): update code style outputs

06b91b3

Fabien Rassinier and others added 4 commits February 19, 2021 18:16

unit tests

d76acb8

chore(ci): update code style outputs

8d3c755

chore(ci): prettier

56e950f

unit tests

f7d3aea

chore(ci): update code style outputs

a560b92

jsomsanith reviewed Feb 22, 2021

View reviewed changes

packages/components/__mocks__/@talend/design-system.js Show resolved Hide resolved

packages/components/src/Tag/Tag.component.js Show resolved Hide resolved

jsomsanith-tlnd approved these changes Feb 24, 2021

View reviewed changes

frassinier removed the easy review label Feb 24, 2021

Kporal approved these changes Feb 24, 2021

View reviewed changes

Merge remote-tracking branch 'origin/master' into frassinier/feat/tags

e4d1bd7

jmfrancois reviewed Feb 24, 2021

View reviewed changes

Fabien Rassinier and others added 2 commits February 24, 2021 10:46

yarn dedupe

ebe4a5e

chore: dedup

103c57a

jmfrancois approved these changes Feb 24, 2021

View reviewed changes

frassinier merged commit 9642a5e into master Feb 24, 2021

frassinier deleted the frassinier/feat/tags branch February 24, 2021 10:37

frassinier mentioned this pull request Apr 6, 2021

Use ThemeProvider on Talend/UI Talend/design-system#23

Closed

feat(components): tags #3164

feat(components): tags #3164

Uh oh!

Conversation

frassinier commented Jan 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

build-travis-ci commented Jan 18, 2021

Uh oh!

build-travis-ci commented Jan 18, 2021

Uh oh!

build-travis-ci commented Jan 19, 2021

Uh oh!

build-travis-ci commented Jan 19, 2021

Uh oh!

jmfrancois Jan 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jmfrancois Jan 19, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

build-travis-ci commented Jan 21, 2021

Uh oh!

jmfrancois Jan 21, 2021

Choose a reason for hiding this comment

Uh oh!

build-travis-ci commented Jan 21, 2021

Uh oh!

build-travis-ci commented Jan 21, 2021

Uh oh!

github-actions bot commented Feb 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

build-travis-ci commented Feb 18, 2021

Uh oh!

build-travis-ci commented Feb 18, 2021

Uh oh!

build-travis-ci commented Feb 18, 2021

Uh oh!

build-travis-ci commented Feb 18, 2021

Uh oh!

build-travis-ci commented Feb 19, 2021

Uh oh!

build-travis-ci commented Feb 19, 2021

Uh oh!

build-travis-ci commented Feb 19, 2021

Uh oh!

build-travis-ci commented Feb 19, 2021

Uh oh!

Uh oh!

Uh oh!

jmfrancois Feb 24, 2021

Choose a reason for hiding this comment

Uh oh!

build-travis-ci commented Feb 24, 2021

Uh oh!

build-travis-ci commented Feb 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

frassinier commented Jan 15, 2021 •

edited

Loading

jmfrancois Jan 19, 2021 •

edited

Loading

jmfrancois Jan 19, 2021 •

edited

Loading

github-actions bot commented Feb 17, 2021 •

edited

Loading