fix(components/TDP-9660): lint errors RatioBar/QualityBar #3158
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trob-tlnd
force-pushed
the
trob-tlnd/feature/TDP-9660_support_popover_menu_@talend_datagrid_quality_bar
branch
from
f90abc8 to
9609f93
Compare
Collaborator
3 similar comments
Collaborator
Collaborator
Collaborator
jmfrancois
approved these changes
Jan 11, 2021
jmfrancois
changed the title
jmfrancois
changed the title
4 tasks
…_menu_@talend_datagrid_quality_bar
trob-tlnd
force-pushed
the
trob-tlnd/feature/TDP-9660_support_popover_menu_@talend_datagrid_quality_bar
branch
from
14e7b9a to
650c6ce
Compare
Collaborator
romainseb
reviewed
Jan 11, 2021
Comment on lines
+56
to
+63
| onClick={ | ||
| onClick | ||
| ? e => | ||
| onClick(e, { | ||
| type: QualityType.INVALID, | ||
| }) | ||
| : null | ||
| } |
Contributor
There was a problem hiding this comment.
Is there a formating issue ? It's looking weird to me
Contributor
Author
There was a problem hiding this comment.
problem of linter ?
Contributor
There was a problem hiding this comment.
Forget about it, looks good now, it was the code that was not formatted well before
Collaborator
romainseb
approved these changes
Jan 11, 2021
trob-tlnd
deleted the
trob-tlnd/feature/TDP-9660_support_popover_menu_@talend_datagrid_quality_bar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem this PR is trying to solve?
#3140 introduced lint errors.
What is the chosen solution to this problem?
fix them all
Please check if the PR fulfills these requirements
[ ] This PR introduces a breaking change