Skip to content

feat(TDP-9660) : Add menu dropdown on quality bar component #3140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trob-tlnd merged 1 commit into from
Jan 7, 2021
Merged

feat(TDP-9660) : Add menu dropdown on quality bar component #3140

trob-tlnd merged 1 commit into from
Jan 7, 2021

Conversation

@trob-tlnd
Copy link
Contributor

@trob-tlnd trob-tlnd commented Dec 21, 2020

What is the problem this PR is trying to solve?

What is the chosen solution to this problem?

Please check if the PR fulfills these requirements

  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@trob-tlnd trob-tlnd force-pushed the trob-tlnd/feature/TDP-9660_support_popover_menu_@talend_datagrid_quality_bar branch from 6113d9d to f92ea89 Compare December 21, 2020 18:22
@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 21, 2020

:octocat: Demo is available here

2 similar comments
@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 21, 2020

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 21, 2020

:octocat: Demo is available here

@trob-tlnd trob-tlnd force-pushed the trob-tlnd/feature/TDP-9660_support_popover_menu_@talend_datagrid_quality_bar branch 4 times, most recently from 82e56af to f0ca724 Compare December 22, 2020 09:17
romainseb
romainseb requested changes Dec 22, 2020
View reviewed changes
Copy link
Contributor

@romainseb romainseb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is some formating issue on some components.
Are you sure your prettier is well configured ?

@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 22, 2020

:octocat: Demo is available here

1 similar comment
@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 22, 2020

:octocat: Demo is available here

@trob-tlnd trob-tlnd force-pushed the trob-tlnd/feature/TDP-9660_support_popover_menu_@talend_datagrid_quality_bar branch 2 times, most recently from 2b76fc8 to aa3f7bc Compare December 22, 2020 10:33
@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 22, 2020

:octocat: Demo is available here

2 similar comments
@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 22, 2020

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 22, 2020

:octocat: Demo is available here

@trob-tlnd trob-tlnd force-pushed the trob-tlnd/feature/TDP-9660_support_popover_menu_@talend_datagrid_quality_bar branch from dade68a to ea5be1b Compare December 22, 2020 12:30
@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 22, 2020

:octocat: Demo is available here

1 similar comment
@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 22, 2020

:octocat: Demo is available here

@trob-tlnd trob-tlnd force-pushed the trob-tlnd/feature/TDP-9660_support_popover_menu_@talend_datagrid_quality_bar branch 5 times, most recently from 08e87bf to 1ce4de0 Compare December 22, 2020 14:22
@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 22, 2020

:octocat: Demo is available here

4 similar comments
@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 22, 2020

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 22, 2020

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 22, 2020

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Dec 22, 2020

:octocat: Demo is available here

@trob-tlnd trob-tlnd requested a review from Kporal January 6, 2021 15:26
romainseb
romainseb reviewed Jan 7, 2021
View reviewed changes
@trob-tlnd trob-tlnd force-pushed the trob-tlnd/feature/TDP-9660_support_popover_menu_@talend_datagrid_quality_bar branch from fd91d80 to fb35f87 Compare January 7, 2021 09:25
gjou-tlnd
gjou-tlnd reviewed Jan 7, 2021
View reviewed changes
@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Jan 7, 2021

:octocat: Demo is available here

@trob-tlnd trob-tlnd force-pushed the trob-tlnd/feature/TDP-9660_support_popover_menu_@talend_datagrid_quality_bar branch 3 times, most recently from d46aed4 to 7cc631d Compare January 7, 2021 10:05
@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Jan 7, 2021

:octocat: Demo is available here

2 similar comments
@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Jan 7, 2021

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Jan 7, 2021

:octocat: Demo is available here

gjou-tlnd
gjou-tlnd suggested changes Jan 7, 2021
View reviewed changes
@trob-tlnd trob-tlnd force-pushed the trob-tlnd/feature/TDP-9660_support_popover_menu_@talend_datagrid_quality_bar branch from 7cc631d to bcbdc77 Compare January 7, 2021 10:36
@trob-tlnd trob-tlnd requested a review from gjou-tlnd January 7, 2021 10:36
gjou-tlnd
gjou-tlnd suggested changes Jan 7, 2021
View reviewed changes
@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Jan 7, 2021

:octocat: Demo is available here

@trob-tlnd trob-tlnd force-pushed the trob-tlnd/feature/TDP-9660_support_popover_menu_@talend_datagrid_quality_bar branch from bcbdc77 to 918f3b8 Compare January 7, 2021 12:14
@trob-tlnd trob-tlnd requested a review from gjou-tlnd January 7, 2021 12:14
@gjou-tlnd gjou-tlnd changed the title feature(TDP-9660) : Add menu dropdown on quality bar component feat(TDP-9660) : Add menu dropdown on quality bar component Jan 7, 2021
@build-travis-ci
Copy link
Collaborator

build-travis-ci commented Jan 7, 2021

:octocat: Demo is available here

@trob-tlnd trob-tlnd merged commit 4ddb90b into master Jan 7, 2021
@trob-tlnd trob-tlnd deleted the trob-tlnd/feature/TDP-9660_support_popover_menu_@talend_datagrid_quality_bar branch January 7, 2021 14:03
This was referenced Jan 11, 2021
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@romainseb romainseb romainseb approved these changes

@Kporal Kporal Awaiting requested review from Kporal

+1 more reviewer

@gjou-tlnd gjou-tlnd gjou-tlnd approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

need review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@trob-tlnd @build-travis-ci @romainseb @gjou-tlnd