Skip to content

Conversation

@frassinier
Copy link
Contributor

@frassinier frassinier commented Jan 20, 2021

What is the problem this PR is trying to solve?
react-popper is still in v1

Usage of popper today in TUI:
Screen Shot 2021-01-11 at 10 47 20

What is the chosen solution to this problem?
move react-popper to v2 with several changes

Please check if the PR fulfills these requirements

  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@frassinier frassinier marked this pull request as draft January 21, 2021 00:14
@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

1 similar comment
@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

2 similar comments
@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@jmfrancois jmfrancois mentioned this pull request Jan 22, 2021
4 tasks
@jmfrancois jmfrancois marked this pull request as ready for review January 22, 2021 15:05
@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

3 similar comments
@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@github-actions
Copy link
Contributor

github-actions bot commented Feb 17, 2021

Size Change: -19.1 kB (-1%)

Total Size: 2.3 MB

Filename Size Change
./packages/components/dist/TalendReactComponents.js 501 kB -12.9 kB (-3%)
./packages/components/dist/TalendReactComponents.js.dependencies.json 815 B +9 B (+1%)
./packages/components/dist/TalendReactComponents.min.js 242 kB -6.43 kB (-3%)
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 811 B +5 B (+1%)
./packages/containers/dist/TalendReactContainers.js.dependencies.json 1.11 kB +27 B (+2%)
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 1.12 kB +31 B (+3%)
./packages/datagrid/dist/TalendReactDatagrid.js.dependencies.json 916 B +23 B (+3%)
./packages/datagrid/dist/TalendReactDatagrid.min.js.dependencies.json 917 B +23 B (+3%)
./packages/forms/dist/TalendReactForms.js.dependencies.json 978 B +29 B (+3%)
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 979 B +27 B (+3%)
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 911 B +28 B (+3%)
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 915 B +31 B (+4%)
ℹ️ View Unchanged
Filename Size Change
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 6.37 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 264 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 2.56 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 263 B 0 B
./packages/cmf/dist/TalendReactCmf.js 93.6 kB 0 B
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 423 B 0 B
./packages/cmf/dist/TalendReactCmf.min.js 31.5 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 423 B 0 B
./packages/components/dist/TalendReactComponents.css 33.8 kB 0 B
./packages/containers/dist/TalendReactContainers.css 533 B 0 B
./packages/containers/dist/TalendReactContainers.js 59.5 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js 25.4 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.css 8.95 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.js 58.9 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.min.js 18.4 kB 0 B
./packages/forms/dist/TalendReactForms.css 4.71 kB 0 B
./packages/forms/dist/TalendReactForms.js 298 kB 0 B
./packages/forms/dist/TalendReactForms.min.js 110 kB 0 B
./packages/icons/dist/bundle.js 2.4 kB 0 B
./packages/icons/dist/info.js 1.95 kB 0 B
./packages/icons/dist/react.esm.js 184 kB 0 B
./packages/icons/dist/react.js 185 kB 0 B
./packages/icons/dist/talend-icons-webfont.css 2.83 kB 0 B
./packages/icons/dist/talendicons.css 199 B 0 B
./packages/icons/dist/TalendIcons.js 190 kB 0 B
./packages/icons/dist/TalendIcons.js.dependencies.json 107 B 0 B
./packages/icons/dist/TalendIcons.min.js 187 kB 0 B
./packages/icons/dist/TalendIcons.min.js.dependencies.json 107 B 0 B
./packages/sagas/dist/TalendReactSagas.js 2.5 kB 0 B
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 264 B 0 B
./packages/sagas/dist/TalendReactSagas.min.js 924 B 0 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 263 B 0 B
./packages/stepper/dist/TalendReactStepper.js 4.83 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js 1.83 kB 0 B
./packages/theme/dist/bootstrap.css 32.5 kB 0 B
./packages/theme/dist/bootstrap.js 569 B 0 B

compressed-size-action

@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

1 similar comment
@build-travis-ci
Copy link
Collaborator

:octocat: Demo is available here

@frassinier frassinier merged commit 25a3d59 into master Feb 17, 2021
@frassinier frassinier deleted the frassinier/chore/react-popper branch February 17, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants