Skip to content

Stateless integrated mode #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

orbitalturtle
Copy link
Contributor

@orbitalturtle orbitalturtle commented Sep 28, 2021

This PR puts integrated stateless mode into practice, as is described here: #160 (comment)

  • Allows Terminal to call lnd rpc via a bufconn when in integrated mode.
  • Doesn't require a TLS certificate for connecting to lnd in integrated mode.
  • Using admin macaroon passed to Terminal, we are able to bake a supermacaroon with permission to access lnd, pool, loop, and faraday.
  • Uses lnd to validate that the supermacaroon has the correct permissions with each rpc call.

I think the backend is working. But it seems the UI is failing to come up after entering a password in this mode, which I still need to look into.

Requires:
lightningnetwork/lnd#5777
lightninglabs/pool#272
lightninglabs/faraday#127
lightninglabs/loop#406

guggero and others added 4 commits September 21, 2021 16:55
With this commit we prepare to use the soon to be releases version
v0.14.0-beta of lnd.
With all the annotations now being extracted into their own yaml files,
we no longer need to include the protos for compilation.
@guggero guggero self-requested a review September 28, 2021 08:43
@guggero guggero force-pushed the lnd-14 branch 6 times, most recently from a966b46 to 50ba325 Compare October 26, 2021 17:52
@guggero guggero force-pushed the lnd-14 branch 2 times, most recently from a444f45 to 76a776e Compare November 4, 2021 12:30
@guggero guggero mentioned this pull request Nov 4, 2021
@guggero
Copy link
Member

guggero commented Nov 4, 2021

Thank you very much for working on this very multi-part project! And sorry it took me so long to finally review this PR.
I think this is very close and just needs a few fixes and optimizations. Would really like to get this into the next major release of LiT and am taking it over. I hope you don't mind!

Replaced by #278.

@guggero guggero closed this Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants