-
Notifications
You must be signed in to change notification settings - Fork 103
Stateless integrated mode #278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm seeing a weird error in the |
4f56a50
to
fc99839
Compare
fc99839
to
0f5c083
Compare
I found and fixed the bug. Stateless integrated mode is now working, with the super macaroon 🎉 So this is ready for full review and test. Again, big kudos to @orbitalturtle for tackling this huge multi-part project! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
The frontend is fully functional from my testing. The only confusion I have is regarding the missing macaroon files for loop
, pool
, and faraday
. Are these intentionally removed? How do we talk to the nodes via CLI? I tried using the admin.macaroon
in my .lnd
dir but that didn't work.
Thank you for the review, @jamaljsr! You are totally correct, those macaroons shouldn't be deleted. Only when the wallet is initialized as |
Just re-tested using commit 6700a2c but now im getting the error below.
|
Thank you for testing! Oops. I know what the problem is, sorry I should've verified it myself first. Will fix tomorrow. |
6700a2c
to
1a361f3
Compare
In integrated mode we hook directly into lnd's bufconn listener for any connections to it. So we don't need any TLS setup and can bake a single super macaroon that is used for all RPC calls.
In case the wallet was initialized in a stateless way, we don't want to create the default macaroons for the faraday/loop/pool daemons. In any other case we do so we can interact with the daemons through the CLI.
1a361f3
to
e84267c
Compare
Replaces #269.
I started reviewing #269 and noticed a few things that could be simplified.
Taking over the PR to speed things up and hopefully get this in with the next major LiT release that also includes
lnd v0.14.0
.