Add option to stop creation of macaroons #406
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See lightninglabs/pool#272 (comment), this also applies here. |
carlaKC
reviewed
Jul 27, 2021
orbitalturtle
changed the title
…rminal Export AllPermissions slice so that we can retrieve the permissions required to run Loop's operations. We need these permissions in Lightning Terminal in order to bake a super macaroon that allows access to Loop.
orbitalturtle
force-pushed
the
macaroon-stateless
branch
from
743d7d4 to
7e694f0
Compare
guggero
force-pushed
the
lnd-14
branch
2 times, most recently
from
0a76208 to
2b1809a
Compare
guggero
force-pushed
the
lnd-14
branch
3 times, most recently
from
778035b to
2c6e035
Compare
|
Oops, I didn't mean to close this, but apparently me removing the |
|
I'm going to take over those PRs so they can hopefully make it into the lnd 0.14.0 release of LiT. I hope you don't mind! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the Lightning Terminal in stateless remote mode (described here: lightninglabs/lightning-terminal#160), Loop shouldn't create a new macaroon. This is a small change to stop macaroons from being created when macaroon data is passed to Loop directly.
Relies on: lightninglabs/lndclient#51