Skip to content

Macaroon stateless #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2021
Merged

Macaroon stateless #428

merged 1 commit into from
Nov 5, 2021

Conversation

guggero
Copy link
Member

@guggero guggero commented Nov 4, 2021

Replaces #406.

In some cases we don't want the default macaroon file to be created on
disk, so we allow passing in a boolean that toggles the macaroon
creation.

This is for the LiT stateless integrated mode.

Pull Request Checklist

  • Update release_notes.md if your PR contains major features, breaking changes or bugfixes

@guggero guggero force-pushed the macaroon-stateless branch from 7affd6b to 4a2cd24 Compare November 4, 2021 13:01
In some cases we don't want the default macaroon file to be created on
disk, so we allow passing in a boolean that toggles the macaroon
creation.
Copy link
Member

@bhandras bhandras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@carlaKC carlaKC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍪

@guggero guggero merged commit 7c4d8f6 into master Nov 5, 2021
@guggero guggero deleted the macaroon-stateless branch June 20, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants