Lnd: Listen for RPC calls on a bufconn #5777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roasbeef
reviewed
Sep 22, 2021
orbitalturtle
force-pushed
the
buf-pass-macaroon
branch
3 times, most recently
from
427cdbf to
2c72f9a
Compare
orbitalturtle
force-pushed
the
buf-pass-macaroon
branch
from
2c72f9a to
b77f6b9
Compare
guggero
reviewed
Sep 27, 2021
orbitalturtle
force-pushed
the
buf-pass-macaroon
branch
2 times, most recently
from
1e30c8d to
5e826de
Compare
orbitalturtle
force-pushed
the
buf-pass-macaroon
branch
from
5e826de to
70bed62
Compare
guggero
reviewed
Sep 30, 2021
orbitalturtle
force-pushed
the
buf-pass-macaroon
branch
from
70bed62 to
e54b7a3
Compare
|
@guggero Terrific, made those changes |
|
Needs a rebase! |
Roasbeef
approved these changes
Oct 1, 2021
orbitalturtle
force-pushed
the
buf-pass-macaroon
branch
from
e54b7a3 to
d3ab556
Compare
guggero
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a couple of pieces that can help us run Terminal in stateless mode, described here: lightninglabs/lightning-terminal#160 (comment).
In short, the first commit adds a field to ListenerCfg for passing in a bufconn to LND, which can be used to listen in-memory RPC calls. It also allows us to pass the admin macaroon back to the program calling LND via a channel.
The second commit adds a GetAllPermissions function that can be used by Terminal to retrieve all the permissions required by LND to bake a "super macaroon" that can be used to interact with lnd as well as Terminal's sub daemons.
(I will also submit a PR to Terminal soon which will show how this all ties together.)