Sync: l2-testnet > pcv/l2-bridge #704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmigone
changed the title
tmigone
requested review from
pcarranzav and
abarmat
and removed request for
pcarranzav and
abarmat
tmigone
force-pushed
the
tmigone/l2-testnet-bridge-sync
branch
2 times, most recently
from
1fac555 to
048952c
Compare
Codecov ReportBase: 91.51% // Head: 91.51% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## pcv/l2-bridge #704 +/- ##
==============================================
Coverage 91.51% 91.51%
==============================================
Files 41 41
Lines 1980 1980
Branches 346 346
==============================================
Hits 1812 1812
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tmigone
force-pushed
the
pcv/l2-bridge
branch
from
e0e2a88 to
b9e7235
Compare
tmigone
force-pushed
the
tmigone/l2-testnet-bridge-sync
branch
from
048952c to
0f708c4
Compare
pcarranzav
reviewed
Sep 6, 2022
tmigone
force-pushed
the
pcv/l2-bridge
branch
from
ae18852 to
5073920
Compare
tmigone
force-pushed
the
tmigone/l2-testnet-bridge-sync
branch
from
34cba23 to
2dc2a5a
Compare
Changes brought from efbee4b Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
…mmon Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
tmigone
force-pushed
the
tmigone/l2-testnet-bridge-sync
branch
from
2dc2a5a to
4931d6e
Compare
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
tmigone
force-pushed
the
tmigone/l2-testnet-bridge-sync
branch
from
09b5cb9 to
7bd7061
Compare
Signed-off-by: Tomás Migone <[email protected]>
Signed-off-by: Tomás Migone <[email protected]>
|
Since we're including the CLI improvements, it might make sense to cherry pick #687 here as well? |
|
Good idea, I'll close the other PR. |
Signed-off-by: Tomás Migone <[email protected]>
tmigone
added a commit
that referenced
this pull request
Sep 23, 2022
Signed-off-by: Tomás Migone <[email protected]> Co-authored-by: Pablo Carranza Vélez <[email protected]> Co-authored-by: Ariel Barmat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cherry picks commits from #659 and #676. Before reviewing and merging, I suggest we merge #703, then rebase
pcv/l2-bridgewith those changes before merging this one:pcv/l2-bridgerebasedChanges