feat: add support for local nitro networks #674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomás Migone <[email protected]>
Codecov Report
@@ Coverage Diff @@
## l2-testnet #674 +/- ##
===========================================
Coverage 92.13% 92.13%
===========================================
Files 44 44
Lines 2137 2137
Branches 370 370
===========================================
Hits 1969 1969
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
abarmat
reviewed
Aug 5, 2022
| @@ -72,7 +72,7 @@ export const migrate = async (cli: CLIEnvironment, cliArgs: CLIArgs): Promise<vo | |||
|
|
|||
| if (chainId == 1337) { | |||
There was a problem hiding this comment.
Once we move the list of contracts to deploy to a config file we won't need this if/case
abarmat
approved these changes
Aug 5, 2022
tmigone
added a commit
that referenced
this pull request
Sep 5, 2022
Signed-off-by: Tomás Migone <[email protected]>
tmigone
added a commit
that referenced
this pull request
Sep 6, 2022
Signed-off-by: Tomás Migone <[email protected]>
tmigone
added a commit
that referenced
this pull request
Sep 6, 2022
Signed-off-by: Tomás Migone <[email protected]>
tmigone
added a commit
that referenced
this pull request
Sep 7, 2022
Signed-off-by: Tomás Migone <[email protected]>
tmigone
added a commit
that referenced
this pull request
Sep 7, 2022
Signed-off-by: Tomás Migone <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR adds the local nitro networks L1 and L2 to hardhat and fixes a few bugs to allow deploying the protocol to those networks.
Changes
evm_setAutomineon local networks. Nitro uses geth in dev mode which already has automine behaviour and doesn't support the RPC call.