Skip to content

feat(e2e): add e2e deployment tests for L2s #676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

tmigone
Copy link
Member

@tmigone tmigone commented Aug 5, 2022

This PR adds task changes and e2e deployment tests for L1/L2. This allows us to validate steps 1.1 through 1.12 with tests (except 1.9 & 1.10 which are pending GRE support for multiple layers).

Changes

  • Add chainId as optional parameter when initializing GRE. This gives some flexibility when choosing where to connect to.
  • hh task e2e no longer runs scenarios, they can be run separately if needed with e2e:scenario.
  • hh task migrate:unpause will unpause the bridge as well as the protocol.
  • Fix bug where migrate:ownership would fail if run on L2.
  • Add L2 e2e deployment tests
  • Add bridge (L1 & L2) e2e tests

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #676 (b8ea9e6) into l2-testnet (19de7a2) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           l2-testnet     #676   +/-   ##
===========================================
  Coverage       92.13%   92.13%           
===========================================
  Files              44       44           
  Lines            2137     2137           
  Branches          370      370           
===========================================
  Hits             1969     1969           
  Misses            168      168           
Flag Coverage Δ
unittests 92.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@tmigone tmigone marked this pull request as draft August 5, 2022 16:26
@tmigone tmigone changed the base branch from dev to l2-testnet August 5, 2022 19:09
@tmigone tmigone marked this pull request as ready for review August 9, 2022 15:51
@tmigone tmigone requested a review from abarmat August 9, 2022 15:57
Copy link
Contributor

@abarmat abarmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we want to merge this on the drip-rewards branch

@tmigone
Copy link
Member Author

tmigone commented Sep 7, 2022

#704 cherry picks commits from here into pcv/l2-bridge. Follow up PR will get the reservoir changes into the drip-rewards branch

@tmigone tmigone marked this pull request as draft September 7, 2022 09:41
@tmigone tmigone mentioned this pull request Sep 7, 2022
2 tasks
@tmigone tmigone changed the title feat: add e2e deployment tests for L2s feat(e2e): add e2e deployment tests for L2s Sep 22, 2022
@tmigone tmigone closed this Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants