refactor: send tokens to L2 #687
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abarmat
force-pushed
the
ariel/cli-send-l2-refactor
branch
from
722b88b to
abe546a
Compare
Codecov Report
@@ Coverage Diff @@
## l2-testnet #687 +/- ##
===========================================
Coverage 92.13% 92.13%
===========================================
Files 44 44
Lines 2137 2137
Branches 370 370
===========================================
Hits 1969 1969
Misses 168 168
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
pcarranzav
reviewed
Aug 24, 2022
| const txReceipt = await sendTransaction(cli.wallet, l1Gateway, 'outboundTransfer', txParams) | ||
|
|
||
| // get l2 ticket status | ||
| if (txReceipt.status == 1) { |
There was a problem hiding this comment.
Should we fail more noisily if txReceipt.status is not 1?
| depositCalldata: string, | ||
| opts: L2GasParams, | ||
| ): Promise<L2GasParams> => { | ||
| const autoEstimate = opts && (!opts.maxGas || !opts.gasPriceBid || !opts.maxSubmissionCost) |
There was a problem hiding this comment.
Is the opts && needed here? I think typescript won't allow it to be null anyways (unless you mark it as optional in the function definition), but in any case if opts is nullish we would want to auto-estimate, wouldn't we?
2 tasks
|
Changes cherry picked onto #704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes