Skip to content

Conversation

@dlaehnemann
Copy link
Member

@dlaehnemann dlaehnemann commented Dec 15, 2025

This goes back to a previous discussion on a now merged pull request:
#46 (comment)

And the tracking pull request over at the release-please GitHub Action for this is here:
googleapis/release-please-action#1172

Summary by CodeRabbit

  • Chores
    • Updated CI/CD workflow configuration to streamline the release process.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 15, 2025

📝 Walkthrough

Walkthrough

Removed a git remote configuration step from the release-please workflow that previously established a remote named gh-token using the GitHub token. No modifications to subsequent tagging or pushing operations.

Changes

Cohort / File(s) Change Summary
GitHub Actions Workflow
​.github/workflows/release-please.yml
Removed git remote addition step that configured authentication with GitHub token for the release-please-action repository

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested reviewers

  • johanneskoester

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing an unused git remote setup that used GitHub token in the release-please workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/remove-unused-token-remote-from-release-please-version

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 29eac74 and 6c6b77d.

📒 Files selected for processing (1)
  • .github/workflows/release-please.yml (0 hunks)
💤 Files with no reviewable changes (1)
  • .github/workflows/release-please.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dlaehnemann dlaehnemann merged commit b46b0bb into master Dec 15, 2025
4 checks passed
@dlaehnemann dlaehnemann deleted the fix/remove-unused-token-remote-from-release-please-version branch December 15, 2025 19:51
@dlaehnemann
Copy link
Member Author

Just to document this:

The updating of the v2 and v2.0 tags from the commit status of v2.0.2 to v2.0.3 seems to have worked properly, so we don't seem to need this weird remote setup after all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants