-
Notifications
You must be signed in to change notification settings - Fork 15
fix: defunct release-please action #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
📝 WalkthroughWalkthroughUpdates GitHub Actions workflows: the PR lint workflow gains explicit triggers, a new name, permission settings, and action v6; the release workflow migrates to googleapis/release-please-action@v4 with top-level permissions and token-based inputs; README Snakemake action examples updated from v1 → v2 and YAML formatting normalized. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
while we are at fixing the snakemake action, there's also this PR here open which should make release please work again @dlaehnemann maybe you can review? |
dlaehnemann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Three little points, which should all be quick to address...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.github/workflows/conventional-prs.yml(2 hunks).github/workflows/release-please.yml(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- .github/workflows/conventional-prs.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build
🔇 Additional comments (3)
.github/workflows/release-please.yml (3)
6-9: Permissions block appropriately configured.The top-level permissions grant the necessary write access for the release workflow to manage contents, pull requests, and issues.
17-22: Action upgrade and checkout positioning look good.The migration to
googleapis/release-please-action@v4with explicit token authentication and the earlier checkout step are aligned with current best practices.
29-36: Major and minor version tagging logic preserved.The tagging logic to create and push major and minor version tags (addressing the prior review feedback from dlaehnemann) is retained and appropriately guards tag creation with the
release_createdcondition.
release-pleaseaction is not working anymore :-(directoryin the README exampleSummary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.