Skip to content

Conversation

@m-jahn
Copy link
Member

@m-jahn m-jahn commented Nov 12, 2025

  • found out with the previous PR that the current release-please action is not working anymore :-(
  • this PR updates the release-please and conventional-prs actions to latest version
  • also adds the missing mandatory directory in the README example

Summary by CodeRabbit

  • Chores

    • Improved PR validation: renamed job/display, expanded triggers, added permissions and updated action versions for PR linting.
    • Streamlined release automation: migrated to the newer release action, switched to token-based auth, updated checkout and tagging flow, and consolidated permissions.
  • Documentation

    • Updated CI example snippets to newer action versions and normalized YAML formatting.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2025

📝 Walkthrough

Walkthrough

Updates GitHub Actions workflows: the PR lint workflow gains explicit triggers, a new name, permission settings, and action v6; the release workflow migrates to googleapis/release-please-action@v4 with top-level permissions and token-based inputs; README Snakemake action examples updated from v1 → v2 and YAML formatting normalized.

Changes

Cohort / File(s) Summary
PR lint workflow
.github/workflows/conventional-prs.yml
Renamed workflow to "Lint PR"; expanded pull_request_target events to opened, reopened, edited, synchronize; job key renamed (title-formatmain) and display name set; added permissions: pull-requests: read; action updated from amannn/[email protected]@v6; GITHUB_TOKEN env retained.
Release workflow
.github/workflows/release-please.yml
Replaced GoogleCloudPlatform/release-please-action@v2 with googleapis/release-please-action@v4; added top-level permissions (write: contents, pull-requests, issues); switched to token-based input token: ${{ secrets.GITHUB_TOKEN }} and kept release-type: go; updated actions/checkout to @v4; removed older gated checkout/manual git steps and updated remote/action references to googleapis.
Documentation
README.md
Snakemake GitHub Action example versions updated from v1v2; YAML normalized to use double quotes and consistent directory, snakefile, and args formatting.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

  • Review points:
    • .github/workflows/release-please.yml: verify new googleapis/release-please-action@v4 inputs/permissions and that automated tagging/push behavior matches prior intent.
    • .github/workflows/conventional-prs.yml: confirm triggers and amannn/action-semantic-pull-request@v6 compatibility with existing title rules.
    • README.md: ensure example YAML changes remain correct for users.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: defunct release-please action' directly addresses the main objective of updating and fixing the non-functional release-please action, which is the primary focus of this changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@m-jahn
Copy link
Member Author

m-jahn commented Dec 11, 2025

while we are at fixing the snakemake action, there's also this PR here open which should make release please work again @dlaehnemann maybe you can review?

Copy link
Member

@dlaehnemann dlaehnemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three little points, which should all be quick to address...

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7fac3c2 and 33167b0.

📒 Files selected for processing (2)
  • .github/workflows/conventional-prs.yml (2 hunks)
  • .github/workflows/release-please.yml (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/conventional-prs.yml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (3)
.github/workflows/release-please.yml (3)

6-9: Permissions block appropriately configured.

The top-level permissions grant the necessary write access for the release workflow to manage contents, pull requests, and issues.


17-22: Action upgrade and checkout positioning look good.

The migration to googleapis/release-please-action@v4 with explicit token authentication and the earlier checkout step are aligned with current best practices.


29-36: Major and minor version tagging logic preserved.

The tagging logic to create and push major and minor version tags (addressing the prior review feedback from dlaehnemann) is retained and appropriately guards tag creation with the release_created condition.

@johanneskoester johanneskoester merged commit c5f3459 into snakemake:master Dec 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants