Don't hardcode the command in the pod specs #1758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
dont-require-cmd
branch
3 times, most recently
from
8c5ba64 to
c3a2601
Compare
Use the entrypoint defined in the image instead. This allows using the other images of the collector where the command is different, e.g. upstream core, k8s or contrib images.
dmitryax
force-pushed
the
dont-require-cmd
branch
from
c3a2601 to
e6a51b4
Compare
mstopa-splunk
approved these changes
Apr 9, 2025
jinja2
approved these changes
Apr 9, 2025
dloucasfx
approved these changes
Apr 9, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the entrypoint defined in the image instead. This allows using the other images of the collector where the command is different, e.g. upstream core, k8s or contrib images.