Skip to content

Don't hardcode the command in the pod specs #1758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 9, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .chloggen/dont-hardcode-command.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
change_type: enhancement
# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
component: all
# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
note: Don't hardcode the command in the pod specs
# One or more tracking issues related to the change
issues: [1758]
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ spec:
initContainers:
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: fluentforward
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ spec:
initContainers:
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: fluentforward
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ spec:
operator: Exists
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: jaeger-grpc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
3 changes: 1 addition & 2 deletions examples/add-sampler/rendered_manifests/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ spec:
operator: Exists
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: jaeger-grpc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,7 @@ spec:
initContainers:
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: fluentforward
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,8 +39,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ spec:
operator: Exists
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: jaeger-grpc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ spec:
operator: Exists
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: jaeger-grpc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ spec:
operator: Exists
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: jaeger-grpc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
3 changes: 1 addition & 2 deletions examples/crio-logging/rendered_manifests/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ spec:
operator: Exists
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: jaeger-grpc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
3 changes: 1 addition & 2 deletions examples/default/rendered_manifests/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ spec:
operator: Exists
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: jaeger-grpc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ spec:
initContainers:
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: fluentforward
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
3 changes: 1 addition & 2 deletions examples/discovery-mode/rendered_manifests/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ spec:
operator: Exists
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
- --discovery
ports:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ spec:
operator: Exists
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: jaeger-grpc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,7 @@ spec:
name: collector-configmap
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/splunk-messages/config.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ spec:
operator: Exists
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: jaeger-grpc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ spec:
operator: Exists
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: jaeger-grpc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,7 @@ spec:
operator: Exists
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: jaeger-grpc
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ spec:
initContainers:
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: fluentforward
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@ spec:
kubernetes.io/os: linux
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
image: quay.io/signalfx/splunk-otel-collector:0.122.0
imagePullPolicy: IfNotPresent
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,7 @@ spec:
initContainers:
containers:
- name: otel-collector
command:
- /otelcol
args:
- --config=/conf/relay.yaml
ports:
- name: fluentforward
Expand Down
Loading
Loading