Don't hardcode the command in the pod specs

Use the entrypoint defined in the image instead. This allows using the other images of the collector where the command is different, e.g. upstream core, k8s or contrib images.

Author: dmitryax

.chloggen/dont-hardcode-command.yaml

@@ -0,0 +1,8 @@
+# One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix'
+change_type: enhancement
+# The name of the component, or a single word describing the area of concern, (e.g. agent, clusterReceiver, gateway, operator, chart, other)
+component: all
+# A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`).
+note: Don't hardcode the command in the pod specs
+# One or more tracking issues related to the change
+issues: [1758]

examples/add-filter-processor/rendered_manifests/daemonset.yaml

@@ -56,8 +56,7 @@ spec:
       initContainers:
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: fluentforward

examples/add-filter-processor/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/add-kafkametrics-receiver/rendered_manifests/daemonset.yaml

@@ -56,8 +56,7 @@ spec:
       initContainers:
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: fluentforward

examples/add-kafkametrics-receiver/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/add-receiver-creator/rendered_manifests/daemonset.yaml

@@ -55,8 +55,7 @@ spec:
           operator: Exists
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: jaeger-grpc

examples/add-receiver-creator/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/add-sampler/rendered_manifests/daemonset.yaml

@@ -55,8 +55,7 @@ spec:
           operator: Exists
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: jaeger-grpc

examples/add-sampler/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/autodetect-istio/rendered_manifests/daemonset.yaml

@@ -57,8 +57,7 @@ spec:
       initContainers:
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: fluentforward

examples/autodetect-istio/rendered_manifests/deployment-cluster-receiver.yaml

@@ -39,8 +39,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/collector-agent-only/rendered_manifests/daemonset.yaml

@@ -55,8 +55,7 @@ spec:
           operator: Exists
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: jaeger-grpc

examples/collector-all-modes/rendered_manifests/daemonset.yaml

@@ -55,8 +55,7 @@ spec:
           operator: Exists
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: jaeger-grpc

examples/collector-all-modes/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/collector-all-modes/rendered_manifests/deployment-gateway.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/collector-cluster-receiver-only/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/collector-gateway-only/rendered_manifests/deployment-gateway.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/controlplane-histogram-metrics/rendered_manifests/daemonset.yaml

@@ -55,8 +55,7 @@ spec:
           operator: Exists
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: jaeger-grpc

examples/controlplane-histogram-metrics/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/crio-logging/rendered_manifests/daemonset.yaml

@@ -55,8 +55,7 @@ spec:
           operator: Exists
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: jaeger-grpc

examples/crio-logging/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/default/rendered_manifests/daemonset.yaml

@@ -55,8 +55,7 @@ spec:
           operator: Exists
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: jaeger-grpc

examples/default/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/disable-persistence-queue-traces/rendered_manifests/daemonset.yaml

@@ -56,8 +56,7 @@ spec:
       initContainers:
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: fluentforward

examples/disable-persistence-queue-traces/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/discovery-mode/rendered_manifests/daemonset.yaml

@@ -55,8 +55,7 @@ spec:
           operator: Exists
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         - --discovery
         ports:

examples/distribution-aks/rendered_manifests/daemonset.yaml

@@ -55,8 +55,7 @@ spec:
           operator: Exists
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: jaeger-grpc

examples/distribution-aks/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/distribution-eks-fargate/rendered_manifests/deployment-cluster-receiver.yaml

@@ -71,8 +71,7 @@ spec:
               name: collector-configmap
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/splunk-messages/config.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/distribution-eks-fargate/rendered_manifests/deployment-gateway.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/distribution-eks/rendered_manifests/daemonset.yaml

@@ -55,8 +55,7 @@ spec:
           operator: Exists
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: jaeger-grpc

examples/distribution-eks/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/distribution-gke-autopilot/rendered_manifests/daemonset.yaml

@@ -56,7 +56,7 @@ spec:
       containers:
       - name: otel-collector
         command:
-        - /otelcol
+        - "/otelcol"
         - --config=/conf/relay.yaml
         ports:
         - name: jaeger-grpc

examples/distribution-gke-autopilot/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/distribution-gke/rendered_manifests/daemonset.yaml

@@ -55,8 +55,7 @@ spec:
           operator: Exists
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: jaeger-grpc

examples/distribution-gke/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/distribution-openshift/rendered_manifests/daemonset.yaml

@@ -55,8 +55,7 @@ spec:
           operator: Exists
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: jaeger-grpc

examples/distribution-openshift/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent

examples/enable-operator-and-auto-instrumentation/rendered_manifests/daemonset.yaml

@@ -56,8 +56,7 @@ spec:
       initContainers:
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         ports:
         - name: fluentforward

examples/enable-operator-and-auto-instrumentation/rendered_manifests/deployment-cluster-receiver.yaml

@@ -38,8 +38,7 @@ spec:
           kubernetes.io/os: linux
       containers:
       - name: otel-collector
-        command:
-        - /otelcol
+        args:
         - --config=/conf/relay.yaml
         image: quay.io/signalfx/splunk-otel-collector:0.122.0
         imagePullPolicy: IfNotPresent