Skip to content

Conversation

@sseago
Copy link

@sseago sseago commented Apr 3, 2025

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

ix-rzi and others added 30 commits March 13, 2025 10:39
* ensure pv has been deleted

Signed-off-by: Roger Zimmermann <[email protected]>

* ensure delete pv unit test

Signed-off-by: Roger Zimmermann <[email protected]>

* comment, errors

Signed-off-by: Roger Zimmermann <[email protected]>

* updated changelog
Signed-off-by: Roger Zimmermann <[email protected]>

Signed-off-by: Roger Zimmermann <[email protected]>

* pass value

Co-authored-by: Tiger Kaovilai <[email protected]>
Signed-off-by: Roger Zimmermann <[email protected]>

* function renamed as suggested

Signed-off-by: Roger Zimmermann <[email protected]>

---------

Signed-off-by: Roger Zimmermann <[email protected]>
Co-authored-by: Tiger Kaovilai <[email protected]>
* fix: log doesn't show pv name

Signed-off-by: hu-keyu <[email protected]>

* fix: add changelog

Signed-off-by: hu-keyu <[email protected]>

* update changelog fileName

Signed-off-by: hu-keyu <[email protected]>

---------

Signed-off-by: hu-keyu <[email protected]>
The restore workflow used name represents the backup resource and the
restore to be restored, but the restored resource name may be different
from the backup one, e.g. PV and VSC are global resources, to avoid
conflict, need to rename them.
Reanme the name variable to backupResourceName, and use obj.GetName()
for restore operation.

Signed-off-by: Xun Jiang <[email protected]>
Fixes vmware-tanzu#8648

Signed-off-by: Tiger Kaovilai <[email protected]>
Modify how the restore workflow using the resource name
)

Bumps [github.com/golang-jwt/jwt/v5](https://github.com/golang-jwt/jwt) from 5.2.1 to 5.2.2.
- [Release notes](https://github.com/golang-jwt/jwt/releases)
- [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md)
- [Commits](golang-jwt/jwt@v5.2.1...v5.2.2)

---
updated-dependencies:
- dependency-name: github.com/golang-jwt/jwt/v5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Issue 8803: use deterministic name to create backupRepository
…ation-for-maintenance-job

Add third party annotation support for maintenance job
…implemented-design

Update readme and implemented design for 1.16
…_1.16

Bump the golang.org/x/net to v0.36.0 to fix Restic CVE.
Signed-off-by: Lyndon-Li <[email protected]>
Migration cases use the Kibishii as the workload, and SC mapping
ConfigMap was needed for all scenarios, because standby cluster
doesn't have the Kibishii SC after setting up.

Signed-off-by: Xun Jiang <[email protected]>
Signed-off-by: Lyndon-Li <[email protected]>
…or_non_data_move

[E2E] Fix the non data mover migration failure.
Add v1.16 related plugin and other image default version.

Signed-off-by: Xun Jiang <[email protected]>
…e_migration_source_version

Bump the migration and upgrade E2E test source version.
…li_and_image_version

Align the E2E upgrade test's CLI and image version.
Signed-off-by: Lyndon-Li <[email protected]>
sseago and others added 18 commits April 3, 2025 09:55
Code-gen no longer required on verify

due to vmware-tanzu#6039

Signed-off-by: Tiger Kaovilai <[email protected]>

oadp-1.2: Update Makefile.prow to velero-restore-helper
Signed-off-by: Mateus Oliveira <[email protected]>
* fix: ARM images

Signed-off-by: Mateus Oliveira <[email protected]>

* fixup! fix: ARM images

Signed-off-by: Mateus Oliveira <[email protected]>

---------

Signed-off-by: Mateus Oliveira <[email protected]>
…openshift#334) (openshift#338)

add missing unit test for kopia hashing algo (openshift#337)

Introduction of downstream only option to override Kopia default:
 - hashing algorithm
 - splitting algorithm
 - encryption algorithm

With introduction of 3 environment variables it is possible to override
Kopia algorithms used by Velero:

KOPIA_HASHING_ALGORITHM
KOPIA_SPLITTER_ALGORITHM
KOPIA_ENCRYPTION_ALGORITHM

If the env algorithms are not set or they are not within
Kopia SupportedAlgorithms, the default algorithm will be used.
This behavior is consistent with current behavior without this
change.

Signed-off-by: Michal Pryc <[email protected]>
Signed-off-by: Shubham Pampattiwar <[email protected]>
The rework of Makefile to make it more readable and
inclusion of lint as a target as well extract
golangci-lint version from the upstream Dockerfile,
so we test in PROW or locally on the same version as upstream.

Signed-off-by: Michal Pryc <[email protected]>
This fixes the PR openshift#334 where one additional line was
in the code. This was not exposed previously as we
did not had downstream CI Lint jobs.

Signed-off-by: Michal Pryc <[email protected]>
* run oadp-operator e2e test from the velero repo

execute openshift/oadp-operator e2e tests directly
against the velero repo locally or via prow ci

Signed-off-by: Wesley Hayutin <[email protected]>

* update variable names, add a cleanup

* make sure env variable overrides default velero_image

Signed-off-by: Wesley Hayutin <[email protected]>

* add options to build, push, and only test

Signed-off-by: Wesley Hayutin <[email protected]>

* add arch to name

Signed-off-by: Wesley Hayutin <[email protected]>

* remove duplicated clean/rm operator checkout

* simplify by dropping export var and use a oneliner

Co-authored-by: Tiger Kaovilai <[email protected]>

* drop export and use oneliner

Co-authored-by: Tiger Kaovilai <[email protected]>

* just in case, allow oadp to be deployed from makefile

Signed-off-by: Wesley Hayutin <[email protected]>

* Update Makefile.prow

Co-authored-by: Tiger Kaovilai <[email protected]>

---------

Signed-off-by: Wesley Hayutin <[email protected]>
Co-authored-by: Tiger Kaovilai <[email protected]>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2025
@openshift-ci
Copy link

openshift-ci bot commented Apr 3, 2025

@sseago: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2025
@shubham-pampattiwar shubham-pampattiwar removed the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 03a4415 into openshift:oadp-1.5 Apr 3, 2025
4 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Apr 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: shubham-pampattiwar, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

weshayutin added a commit that referenced this pull request Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.