issue8720: log doesn't show pv name #8771

hu-keyu · 2025-03-10T09:39:34Z

Thank you for contributing to Velero!

Please add a summary of your change

Log doesn't show pv name.

Does your change fix a particular issue?

Fixes #8720

Please indicate you've done the following:

Accepted the DCO. Commits without the DCO will delay acceptance.
Created a changelog file (make new-changelog) or comment /kind changelog-not-required on this PR.
Updated the corresponding documentation in site/content/docs/main.

codecov · 2025-03-10T13:23:15Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.06%. Comparing base (1516e72) to head (395f25b).
Report is 14 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8771      +/-   ##
==========================================
+ Coverage   59.53%   60.06%   +0.52%     
==========================================
  Files         371      372       +1     
  Lines       40196    40932     +736     
==========================================
+ Hits        23932    24587     +655     
- Misses      14767    14853      +86     
+ Partials     1497     1492       -5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

kaovilai · 2025-03-10T13:26:55Z

Please write changelog or comment /kind changelog-not-required

sseago · 2025-03-10T17:27:48Z

@kaovilai actually the changelog is here but it has the wrong name.

changelogs/unreleased/8720-hu-keyu

kaovilai · 2025-03-10T17:34:07Z

Don't be alarmed about e2e tests.. unrelated to PR #8766

Signed-off-by: hu-keyu <[email protected]>

hu-keyu · 2025-03-13T06:35:42Z

Can this PR be merged? @Lyndon-Li @blackpiglet

* Issue vmware-tanzu#8772 ensure pv removed (vmware-tanzu#8777) * ensure pv has been deleted Signed-off-by: Roger Zimmermann <[email protected]> * ensure delete pv unit test Signed-off-by: Roger Zimmermann <[email protected]> * comment, errors Signed-off-by: Roger Zimmermann <[email protected]> * updated changelog Signed-off-by: Roger Zimmermann <[email protected]> Signed-off-by: Roger Zimmermann <[email protected]> * pass value Co-authored-by: Tiger Kaovilai <[email protected]> Signed-off-by: Roger Zimmermann <[email protected]> * function renamed as suggested Signed-off-by: Roger Zimmermann <[email protected]> --------- Signed-off-by: Roger Zimmermann <[email protected]> Co-authored-by: Tiger Kaovilai <[email protected]> * issue8720: log doesn't show pv name (vmware-tanzu#8771) * fix: log doesn't show pv name Signed-off-by: hu-keyu <[email protected]> * fix: add changelog Signed-off-by: hu-keyu <[email protected]> * update changelog fileName Signed-off-by: hu-keyu <[email protected]> --------- Signed-off-by: hu-keyu <[email protected]> * Bump kind cli to v0.27.0 (vmware-tanzu#8699) Signed-off-by: Tiger Kaovilai <[email protected]> * Modify how the restore workflow using the resource name. The restore workflow used name represents the backup resource and the restore to be restored, but the restored resource name may be different from the backup one, e.g. PV and VSC are global resources, to avoid conflict, need to rename them. Reanme the name variable to backupResourceName, and use obj.GetName() for restore operation. Signed-off-by: Xun Jiang <[email protected]> * Enable containerdv2 images Fixes vmware-tanzu#8648 Signed-off-by: Tiger Kaovilai <[email protected]> * Bump github.com/golang-jwt/jwt/v5 from 5.2.1 to 5.2.2 (vmware-tanzu#8806) Bumps [github.com/golang-jwt/jwt/v5](https://github.com/golang-jwt/jwt) from 5.2.1 to 5.2.2. - [Release notes](https://github.com/golang-jwt/jwt/releases) - [Changelog](https://github.com/golang-jwt/jwt/blob/main/VERSION_HISTORY.md) - [Commits](golang-jwt/jwt@v5.2.1...v5.2.2) --- updated-dependencies: - dependency-name: github.com/golang-jwt/jwt/v5 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Document schedule skipImmediately (vmware-tanzu#8802) Fixes vmware-tanzu#8787 Signed-off-by: Tiger Kaovilai <[email protected]> * issue 8803: use deterministic name to create backupRepository Signed-off-by: Lyndon-Li <[email protected]> * add third party annotation support for maintenance job Signed-off-by: Lyndon-Li <[email protected]> * Bump the golang.org/x/net to v0.36.0 to fix Restic CVE. Signed-off-by: Xun Jiang <[email protected]> * update readme and implemented design for 1.16 Signed-off-by: Lyndon-Li <[email protected]> * add doc for upgrade to 1.16 Signed-off-by: Lyndon-Li <[email protected]> * add 1.16 doc Signed-off-by: Lyndon-Li <[email protected]> * Fix the non data mover migration failure. Migration cases use the Kibishii as the workload, and SC mapping ConfigMap was needed for all scenarios, because standby cluster doesn't have the Kibishii SC after setting up. Signed-off-by: Xun Jiang <[email protected]> * add 1.16 changelog Signed-off-by: Lyndon-Li <[email protected]> * Bump the migration and upgrade E2E test source version. Add v1.16 related plugin and other image default version. Signed-off-by: Xun Jiang <[email protected]> * Align the E2E upgrade test's CLI and image version. Signed-off-by: Xun Jiang <[email protected]> * pin velero image Signed-off-by: Lyndon-Li <[email protected]> * skip subresource in resource discovery (vmware-tanzu#6688) Signed-off-by: lou <[email protected]> Co-authored-by: lou <[email protected]> * fix issue 6753 Signed-off-by: Lyndon-Li <[email protected]> * Update restore controller logic for restore deletion (vmware-tanzu#6761) 1. Skip deleting the restore files from storage if the backup/BSL is not found 2. Allow deleting the restore files from storage even though the BSL is readonly Signed-off-by: Wenkai Yin(尹文开) <[email protected]> * Fix vmware-tanzu#6752: add namespace exclude check. Add PSA audit and warn labels. Signed-off-by: Xun Jiang <[email protected]> * add csi snapshot data movement doc Signed-off-by: Lyndon-Li <[email protected]> * Modify changelogs for v1.12 Signed-off-by: allenxu404 <[email protected]> * issue 6786:always delete VSC regardless of the deletion policy Signed-off-by: Lyndon-Li <[email protected]> * issue: move plugin depdending podvolume functions to util pkg Signed-off-by: Lyndon-Li <[email protected]> * issue 6880: set ParallelUploadAboveSize as MaxInt64 Signed-off-by: Lyndon-Li <[email protected]> * changelog Signed-off-by: Tiger Kaovilai <[email protected]> * Add support for block volumes (vmware-tanzu#6680) (vmware-tanzu#6897) (cherry picked from commit 8e01d1b) Signed-off-by: David Zaninovic <[email protected]> * Replace the base image with paketobuildpacks image Replace the base image with paketobuildpacks image Fixes vmware-tanzu#6851 Signed-off-by: Wenkai Yin(尹文开) <[email protected]> * issue 6734: spread backup pod evenly Signed-off-by: Lyndon-Li <[email protected]> * Add doc links for new features to release note Signed-off-by: allenxu404 <[email protected]> * fix issue 6647 Signed-off-by: Lyndon-Li <[email protected]> * Perf improvements for existing resource restore Use informer cache with dynamic client for Get calls on restore When enabled, also make the Get call before create. Add server and install parameter to allow disabling this feature, but enable by default Signed-off-by: Scott Seago <[email protected]> * issue vmware-tanzu#6807: Retry failed create when using generateName When creating resources with generateName, apimachinery does not guarantee uniqueness when it appends the random suffix to the generateName stub, so if it fails with already exists error, we need to retry. Signed-off-by: Scott Seago <[email protected]> * Import auth provider plugins Signed-off-by: Sebastian Glab <[email protected]> * Add v1.12.1 changelog Signed-off-by: allenxu404 <[email protected]> * Make Windows build skip BlockMode code. PVC block mode backup and restore introduced some OS specific system calls. Those calls are not available for Windows, so add both non Windows version and Windows version code, and return error for block mode on the Windows platform. Signed-off-by: Xun Jiang <[email protected]> * udmrepo use region specified in BSL when s3URL is empty Signed-off-by: Lyndon-Li <[email protected]> * Change v1.12.1 changelog Signed-off-by: allenxu404 <[email protected]> * Dockerfile.ubi/travis local files add UBI dockerfiles Use numeric user for velero-restic-restore-helper Enable multiarch builds (#135) Use arm64-graviton2 for arm builds (#137) Add required keys for arm builds (#139) Update Travis build job to work w/o changes on new branches Use a full VM for arm Use numeric non-root user for nonroot SCC compatibility * Add BZ + Publish automation to repo (#82) (cherry picked from commit ccb545f) Update PR-BZ automation mapping (#84) (cherry picked from commit aa2b019) Update PR-BZ automation (#92) Co-authored-by: Rayford Johnson <[email protected]> (cherry picked from commit ecc563f) Add publish workflow (#108) (cherry picked from commit f87b779) * remove dependabot config from fork * Create Makefile.prow Code-gen no longer required on verify due to vmware-tanzu#6039 Signed-off-by: Tiger Kaovilai <[email protected]> oadp-1.2: Update Makefile.prow to velero-restore-helper * set HOME in velero image for kopia, update controller-gen for CI (#280) Signed-off-by: Scott Seago <[email protected]> * build velero-helper binary for datamover pod * restore: Use warning when Create IsAlreadyExist and Get error Signed-off-by: Tiger Kaovilai <[email protected]> * kopia/repository/config/aws.go: Set session.Options profile from config Signed-off-by: Tiger Kaovilai <[email protected]> * use ubi9-latest to build * OADP-4225: add tzdata to Dockerfile.ubi * fix: CI (#316) Signed-off-by: Mateus Oliveira <[email protected]> * fix: ARM images (#332) * fix: ARM images Signed-off-by: Mateus Oliveira <[email protected]> * fixup! fix: ARM images Signed-off-by: Mateus Oliveira <[email protected]> --------- Signed-off-by: Mateus Oliveira <[email protected]> * ubi: BUILDPLATFORM to build stage to enable cross compile. (#336) Signed-off-by: Tiger Kaovilai <[email protected]> * OADP-4640: Downstream only to allow override kopia default algorithms (#334) (#338) add missing unit test for kopia hashing algo (#337) Introduction of downstream only option to override Kopia default: - hashing algorithm - splitting algorithm - encryption algorithm With introduction of 3 environment variables it is possible to override Kopia algorithms used by Velero: KOPIA_HASHING_ALGORITHM KOPIA_SPLITTER_ALGORITHM KOPIA_ENCRYPTION_ALGORITHM If the env algorithms are not set or they are not within Kopia SupportedAlgorithms, the default algorithm will be used. This behavior is consistent with current behavior without this change. Signed-off-by: Michal Pryc <[email protected]> Signed-off-by: Shubham Pampattiwar <[email protected]> * Downstream only: Rework of Makefile and incusion of lint The rework of Makefile to make it more readable and inclusion of lint as a target as well extract golangci-lint version from the upstream Dockerfile, so we test in PROW or locally on the same version as upstream. Signed-off-by: Michal Pryc <[email protected]> * Downstream only - fix lint error in downtream change (#343) This fixes the PR #334 where one additional line was in the code. This was not exposed previously as we did not had downstream CI Lint jobs. Signed-off-by: Michal Pryc <[email protected]> * run oadp-operator e2e test from the velero repo (#353) * run oadp-operator e2e test from the velero repo execute openshift/oadp-operator e2e tests directly against the velero repo locally or via prow ci Signed-off-by: Wesley Hayutin <[email protected]> * update variable names, add a cleanup * make sure env variable overrides default velero_image Signed-off-by: Wesley Hayutin <[email protected]> * add options to build, push, and only test Signed-off-by: Wesley Hayutin <[email protected]> * add arch to name Signed-off-by: Wesley Hayutin <[email protected]> * remove duplicated clean/rm operator checkout * simplify by dropping export var and use a oneliner Co-authored-by: Tiger Kaovilai <[email protected]> * drop export and use oneliner Co-authored-by: Tiger Kaovilai <[email protected]> * just in case, allow oadp to be deployed from makefile Signed-off-by: Wesley Hayutin <[email protected]> * Update Makefile.prow Co-authored-by: Tiger Kaovilai <[email protected]> --------- Signed-off-by: Wesley Hayutin <[email protected]> Co-authored-by: Tiger Kaovilai <[email protected]> * DS Owners * updated controller-gen version * Include velero-restore-helper binary in velero image (#375) Co-authored-by: Scott Seago <[email protected]> --------- Signed-off-by: Roger Zimmermann <[email protected]> Signed-off-by: hu-keyu <[email protected]> Signed-off-by: Tiger Kaovilai <[email protected]> Signed-off-by: Xun Jiang <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Lyndon-Li <[email protected]> Signed-off-by: lou <[email protected]> Signed-off-by: Wenkai Yin(尹文开) <[email protected]> Signed-off-by: Xun Jiang <[email protected]> Signed-off-by: allenxu404 <[email protected]> Signed-off-by: David Zaninovic <[email protected]> Signed-off-by: Scott Seago <[email protected]> Signed-off-by: Sebastian Glab <[email protected]> Signed-off-by: Mateus Oliveira <[email protected]> Signed-off-by: Michal Pryc <[email protected]> Signed-off-by: Shubham Pampattiwar <[email protected]> Signed-off-by: Wesley Hayutin <[email protected]> Co-authored-by: Roger Zimmermann <[email protected]> Co-authored-by: Tiger Kaovilai <[email protected]> Co-authored-by: hu-keyu <[email protected]> Co-authored-by: Tiger Kaovilai <[email protected]> Co-authored-by: Xun Jiang <[email protected]> Co-authored-by: lyndon-li <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wenkai Yin(尹文开) <[email protected]> Co-authored-by: Lyndon-Li <[email protected]> Co-authored-by: Xun Jiang/Bruce Jiang <[email protected]> Co-authored-by: Daniel Jiang <[email protected]> Co-authored-by: lou <[email protected]> Co-authored-by: Xun Jiang <[email protected]> Co-authored-by: allenxu404 <[email protected]> Co-authored-by: David Zaninovic <[email protected]> Co-authored-by: Sebastian Glab <[email protected]> Co-authored-by: Dylan Murray <[email protected]> Co-authored-by: RayfordJ <[email protected]> Co-authored-by: Mateus Oliveira <[email protected]> Co-authored-by: Michal Pryc <[email protected]> Co-authored-by: Wesley Hayutin <[email protected]> Co-authored-by: OpenShift Cherrypick Robot <[email protected]>

* fix: log doesn't show pv name Signed-off-by: hu-keyu <[email protected]> * fix: add changelog Signed-off-by: hu-keyu <[email protected]> * update changelog fileName Signed-off-by: hu-keyu <[email protected]> --------- Signed-off-by: hu-keyu <[email protected]>

github-actions bot added the has-changelog label Mar 10, 2025

github-actions bot requested a review from Lyndon-Li March 10, 2025 09:39

github-actions bot assigned hu-keyu Mar 10, 2025

github-actions bot requested a review from sseago March 10, 2025 09:39

hu-keyu force-pushed the fix-8720 branch from 5c90fc8 to a28de37 Compare March 10, 2025 09:40

hu-keyu mentioned this pull request Mar 10, 2025

Minor log issue: Log doesn't show pv name, but displays %!s(MISSING) instead #8720

Closed

shubham-pampattiwar previously approved these changes Mar 10, 2025

View reviewed changes

kaovilai previously approved these changes Mar 10, 2025

View reviewed changes

sseago reviewed Mar 10, 2025

View reviewed changes

changelogs/unreleased/8720-hu-keyu Show resolved Hide resolved

hu-keyu dismissed stale reviews from kaovilai and shubham-pampattiwar via e5d48a3 March 11, 2025 01:39

hu-keyu added 3 commits March 11, 2025 09:41

fix: log doesn't show pv name

e373003

Signed-off-by: hu-keyu <[email protected]>

fix: add changelog

72b6652

Signed-off-by: hu-keyu <[email protected]>

update changelog fileName

395f25b

Signed-off-by: hu-keyu <[email protected]>

hu-keyu force-pushed the fix-8720 branch from e5d48a3 to 395f25b Compare March 11, 2025 01:41

hu-keyu removed their assignment Mar 11, 2025

shubham-pampattiwar approved these changes Mar 11, 2025

View reviewed changes

blackpiglet approved these changes Mar 11, 2025

View reviewed changes

hu-keyu requested review from blackpiglet, kaovilai, shubham-pampattiwar and sseago March 11, 2025 08:40

shubham-pampattiwar approved these changes Mar 11, 2025

View reviewed changes

sseago approved these changes Mar 11, 2025

View reviewed changes

kaovilai approved these changes Mar 11, 2025

View reviewed changes

kaovilai closed this Mar 13, 2025

kaovilai reopened this Mar 13, 2025

github-actions bot assigned hu-keyu Mar 13, 2025

github-actions bot requested review from reasonerjt and sseago March 13, 2025 21:23

kaovilai enabled auto-merge (squash) March 13, 2025 21:24

kaovilai disabled auto-merge March 13, 2025 21:24

kaovilai merged commit 0d27d52 into vmware-tanzu:main Mar 13, 2025
75 of 83 checks passed

MaloLelandais mentioned this pull request Jul 28, 2025

Rebase velero clcondorcet/velero#1

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

issue8720: log doesn't show pv name #8771

issue8720: log doesn't show pv name #8771

Uh oh!

hu-keyu commented Mar 10, 2025 •

edited

Loading

Uh oh!

codecov bot commented Mar 10, 2025 •

edited

Loading

Uh oh!

kaovilai commented Mar 10, 2025

Uh oh!

sseago commented Mar 10, 2025

Uh oh!

Uh oh!

kaovilai commented Mar 10, 2025

Uh oh!

hu-keyu commented Mar 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

issue8720: log doesn't show pv name #8771

issue8720: log doesn't show pv name #8771

Uh oh!

Conversation

hu-keyu commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Please add a summary of your change

Does your change fix a particular issue?

Please indicate you've done the following:

Uh oh!

codecov bot commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

kaovilai commented Mar 10, 2025

Uh oh!

sseago commented Mar 10, 2025

Uh oh!

Uh oh!

kaovilai commented Mar 10, 2025

Uh oh!

hu-keyu commented Mar 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

hu-keyu commented Mar 10, 2025 •

edited

Loading

codecov bot commented Mar 10, 2025 •

edited

Loading