Skip to content

Conversation

@blackpiglet
Copy link
Contributor

@blackpiglet blackpiglet commented Mar 27, 2025

Migration cases use the Kibishii as the workload, and SC mapping ConfigMap was needed for all scenarios, because standby cluster doesn't have the Kibishii SC after setting up.

Thank you for contributing to Velero!

Please add a summary of your change

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

Migration cases use the Kibishii as the workload, and SC mapping
ConfigMap was needed for all scenarios, because standby cluster
doesn't have the Kibishii SC after setting up.

Signed-off-by: Xun Jiang <[email protected]>
@blackpiglet blackpiglet added kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes E2E Tests End to end test labels Mar 27, 2025
@blackpiglet blackpiglet requested a review from Copilot March 27, 2025 16:07
@blackpiglet blackpiglet self-assigned this Mar 27, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a migration failure in non-data mover scenarios by removing the condition that limited the creation of the SC mapping ConfigMap. Key changes include the removal of the conditional check on m.VeleroCfg.SnapshotMoveData, ensuring that the ConfigMap is created for all migration cases.

Comments suppressed due to low confidence (1)

test/e2e/migration/migration.go:358

  • [nitpick] Removal of the conditional check for m.VeleroCfg.SnapshotMoveData now unconditionally creates the ConfigMap. Consider adding an inline comment to clarify that this behavior is intentional for covering all migration scenarios.
if m.VeleroCfg.SnapshotMoveData {

@codecov
Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.54%. Comparing base (bea46e3) to head (6a0c6d5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8826   +/-   ##
=======================================
  Coverage   59.54%   59.54%           
=======================================
  Files         370      370           
  Lines       40239    40239           
=======================================
  Hits        23961    23961           
  Misses      14778    14778           
  Partials     1500     1500           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ywk253100 ywk253100 merged commit 8f8884f into vmware-tanzu:main Mar 28, 2025
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

E2E Tests End to end test has-e2e-2tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants