chore: Migrate Hero component #5366

ktssr · 2023-05-08T15:25:36Z

Description

Related Issues

Check List

I have read the Contributing Guidelines and made commit messages that follow the guideline.
I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
I have run npx turbo format to ensure the code follows the style guide.
I have run npx turbo test to check if all tests are passing, and/or npx turbo test:snapshot to update snapshots if I created and/or updated React Components.
I've covered new added functionality with unit tests if necessary.

Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Wai.Tung <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: vasanth9 <cheepurupalli.vasanthkumar.com> Co-authored-by: Aymen Naghmouchi <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: Guilherme Araújo <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: HinataKah0 <[email protected]> Co-authored-by: Olaleye Blessing <[email protected]> Co-authored-by: ktssr <[email protected]> Co-authored-by: vasanthkumar <[email protected]> Co-authored-by: Floran Hachez <[email protected]> Co-authored-by: Jatin <[email protected]> fixed styleling misconfig and fixed storybooks (nodejs#5281) fix storybook styles, imports, typescript config and dependencies (nodejs#5319 fix(package.json) Lint command is missing slashes (nodejs#5321 fix storybook local development mode (nodejs#5335) fix(i18n): translation key (nodejs#5347)

vercel · 2023-05-08T15:25:40Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 19, 2023 8:33am
nodejs-org-stories	❌ Failed (Inspect)			May 19, 2023 8:33am

AugustinMauroy

LGTM

AugustinMauroy · 2023-05-09T09:56:37Z

components/Home/Hero/__tests__/index.test.tsx

+import Hero from '..';
+import type { NodeReleaseData } from '../../../../types';
+
+const mockNodeReleaseData: NodeReleaseData[] = [


We should create fixture I thinks it's will ship with this

I believe that mocking like this should be sufficient for this test file.

Yes, but since we are going to test all the components of the Download page. Better to have a unique mock for all the tests. What do you think about it?

As the fixture is already in progress, Is there any action item for me?

Leave as is and update when the fixture is available.

@HinataKah0's PR is almost ready so, we should be able to very soon use their fixtures!

… method (nodejs#5369) Add clarity to step 4 based on clone method Signed-off-by: Vessy Shestorkina <[email protected]>

ovflowd · 2023-05-11T23:38:42Z

components/Home/Hero/index.module.scss

@@ -0,0 +1,110 @@
+@use '../../../styles/typography.scss';


Why this import is needed? 🤔

We are extending .t-subheading from this file in line number 25

Harkunwar · 2023-05-12T01:16:32Z

Hello @ktssr , could you run npm run test:storybook:snapshot to add snapshots. That is the reason your tests are failing.

AugustinMauroy · 2023-05-12T18:40:47Z

components/Home/Hero/index.stories.tsx

+    title: 'Run JavaScript Everywhere.',
+    subTitle:
+      'Node.js is a free, open-sourced, cross-platform JavaScript run-time environment that lets developers write command line tools and server-side scripts outside of a browser.',
+    nodeReleaseData: [


this will also use the fixture

Is there any reason for this. This is being used only in single test unlike NodeReleaseData?

we should create an fixture to gather all thing in one point.

* Migrate JsonLink component Signed-off-by: Vessy Shestorkina <[email protected]> * Add storybook snap and robot icon Signed-off-by: Vessy Shestorkina <[email protected]> * Remove IconContext provider Signed-off-by: Vessy Shestorkina <[email protected]> --------- Signed-off-by: Vessy Shestorkina <[email protected]> Signed-off-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]>

…s#5376) * refactor(useDownloadLink): Move useDetectOs to useDownloadLink * refactor(useDownloadLink): rename file * refactor(useDownloadLink): rename file * Apply suggestions from code review Signed-off-by: Claudio Wunder <[email protected]> * refactor(useDownloadLink): undo deleted file --------- Signed-off-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]>

* feat: Add MUI Config and Theme Provider * added createTheme * refactor themeConfig * feat(theme): Fix linting and package-lock * feat(theme): Add emotion styled and emtion react --------- Co-authored-by: Harkunwar Kochar <[email protected]>

refactor(test): Delete duplicate test file Co-authored-by: Claudio Wunder <[email protected]>

* feat(useClickOutside): introduce * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * feat(useClickOutside): fix and twix * feat(dropdown): remove useless ref * feat(useClickOutside): update unit test * feat(UseClickOutside): update type * fix: usage of type * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * update listener * Update components/Common/LanguageSelector/index.tsx Co-authored-by: Shanmughapriyan S <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * fix: languageSelector * update with feedback * better unit test * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * feat(useClickOutside): update with feedback * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * fix: if click on modal * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update hooks/useClickOutside.ts Signed-off-by: Harkunwar Kochar <[email protected]> * Update hooks/useClickOutside.ts Co-authored-by: Harkunwar Kochar <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update useClickOutside.ts * Update hooks/useClickOutside.ts Co-authored-by: Shanmughapriyan S <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update useClickOutside.ts * Apply suggestions from code review Signed-off-by: Claudio Wunder <[email protected]> * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * Update hooks/useClickOutside.ts Co-authored-by: Claudio Wunder <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]> * fix: build --------- Signed-off-by: Augustin Mauroy <[email protected]> Signed-off-by: Harkunwar Kochar <[email protected]> Signed-off-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Harkunwar Kochar <[email protected]>

* feat: create codebox component * feat: add pointer to copy button * feat: add shell support * feat: use code element instead of pre * chore: fix eslint issues * refactor: remove shell codebox * refactor: use react.fc type * refactor: remove duplicate encoding * refactor: use pre element for codebox * style: some eol * style: some eol * refactor: use pre element for codebox * chore: create inlinecode story * refactor: create inline code story type * chore: revert .browserslistrc * test: remove duplicated test * test: remove beginning space on code * refactor: setup userEvent on tests * refactor: remove useless async * test: manual mock isomorphic-dompurify * fix: some fixes * chore: create multi lang story * test: snapshot before and after switch lang * refactor: inline mock * refactor: use decorators * chore: split inlinecode component * feat: add selected lang state * refactor: add inlinecode decorator * refactor: remove duplicate classes * chore: revert .browserslistrc * test: fix tests * chore: wip * feat: use story component arg * style: stories * test: remove i18n from clipboard test * chore: migrate pagination component (nodejs#5331) Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * chore: add a proper decorated component * refactor: decorated inline code * Chore(node feat) (nodejs#5338) Co-authored-by: Claudio Wunder <[email protected]> * (website redesign) Feat(shellbox): migration (nodejs#5234) Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * fix(i18n): translation key (nodejs#5347) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * feat: add hover states * chore: fix rebase leftovers * chore: update snapshots * chore: install @types/prismjs * Update index.stories.tsx Signed-off-by: Claudio Wunder <[email protected]> * chore: remove duplicate snapshots * chore: remove duplicate snapshot --------- Signed-off-by: Claudio Wunder <[email protected]> Co-authored-by: ktssr <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]>

* Migrate: Source-link * Fix: JSON key moved to the end of the file * Test: Storybook snapshot test --------- Signed-off-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]>

Signed-off-by: Wai.Tung <[email protected]>

vercel · 2023-05-19T05:37:30Z

@MaledongGit is attempting to deploy a commit to the OpenJS Foundation Team on Vercel.

A member of the Team first needs to authorize it.

* feat: introduce built-in next.js exports and updated scripts and configs (nodejs#5384) * chore: updated gitignore and rmeoved robots.txt * chore: updated next-sitemap config * chore: next-config refactored options and export support * chore: updated imports to node: prefix * chore: updated contributing guidelines * chore: updated scripts * chore: updated next-sitemap * chore: added missing props * fix: github-pages * chore: remove unused package * fix(storybook): update packages (nodejs#5386) --------- Co-authored-by: Harkunwar Kochar <[email protected]>

ovflowd · 2023-05-24T13:39:07Z

FYI: We deleted the major/website-redesign branch to simplify our release and rollout process. Please feel free to recreate this PR or reopen it with the main branch as a target.

Thank you, and we apologise for the inconvenience!

ktssr · 2023-05-25T02:04:50Z

FYI: We deleted the major/website-redesign branch to simplify our release and rollout process. Please feel free to recreate this PR or reopen it with the main branch as a target.

Thank you, and we apologise for the inconvenience!

How about the fixture is it created

ovflowd · 2023-05-25T09:17:00Z

Hey @ktssr not yet! @HinataKah0 was waiting on some changes to happen on @nodevu/core, and they got merged this week!

vercel bot temporarily deployed to Preview – nodejs-org May 8, 2023 15:26 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories May 8, 2023 15:27 Inactive

AugustinMauroy reviewed May 9, 2023

View reviewed changes

HinataKah0 and others added 3 commits May 11, 2023 10:14

chore: no-unused-vars ignores pattern starting with _ (nodejs#5363)

c526a02

Contributing Guidelines Update - Add clarity to step 4 based on clone…

566f3d9

… method (nodejs#5369) Add clarity to step 4 based on clone method Signed-off-by: Vessy Shestorkina <[email protected]>

fix(test): dir name (nodejs#5354)

49efa04

ovflowd reviewed May 11, 2023

View reviewed changes

chore: Migrate Hero component

d30b503

ktssr force-pushed the chore/migrate-hero-component branch from 38b55bf to d30b503 Compare May 12, 2023 08:32

vercel bot temporarily deployed to Preview – nodejs-org May 12, 2023 08:35 Inactive

vercel bot temporarily deployed to Preview – nodejs-org-stories May 12, 2023 08:36 Inactive

AugustinMauroy reviewed May 12, 2023

View reviewed changes

feat:checked in storybook test snapshot

401e2ea

vercel bot temporarily deployed to Preview – nodejs-org-stories May 13, 2023 04:32 Inactive

vercel bot temporarily deployed to Preview – nodejs-org May 13, 2023 04:33 Inactive

AugustinMauroy and others added 10 commits May 14, 2023 09:10

feat(stability): migrate component (nodejs#5339)

a51457d

refactor(delete): duplicate test file (nodejs#5377)

a8fa762

refactor(test): Delete duplicate test file Co-authored-by: Claudio Wunder <[email protected]>

Merge branch 'main' into major/website-redesign

51128c3

Migrate: Source-link (nodejs#5364)

c254c60

* Migrate: Source-link * Fix: JSON key moved to the end of the file * Test: Storybook snapshot test --------- Signed-off-by: Claudio Wunder <[email protected]> Co-authored-by: Claudio Wunder <[email protected]>

Merge branch 'major/website-redesign' into chore/migrate-hero-component

bf9f76f

Signed-off-by: Wai.Tung <[email protected]>

vercel bot temporarily deployed to Preview – nodejs-org-stories May 19, 2023 05:38 Inactive

ovflowd and others added 2 commits May 19, 2023 10:29

Merge branch 'major/website-redesign' into chore/migrate-hero-component

0575861

vercel bot temporarily deployed to Preview – nodejs-org-stories May 19, 2023 08:33 Inactive

ovflowd force-pushed the major/website-redesign branch from cb8c95e to 9243764 Compare May 24, 2023 13:33

ovflowd requested a review from a team as a code owner May 24, 2023 13:33

ovflowd deleted the branch nodejs:major/website-redesign May 24, 2023 13:37

ovflowd closed this May 24, 2023

ktssr deleted the chore/migrate-hero-component branch July 8, 2023 14:52

Uh oh!

chore: Migrate Hero component #5366

chore: Migrate Hero component #5366

Uh oh!

Conversation

ktssr commented May 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related Issues

Check List

Uh oh!

vercel bot commented May 8, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AugustinMauroy left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ktssr May 12, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Harkunwar commented May 12, 2023

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vercel bot commented May 19, 2023

Uh oh!

ovflowd commented May 24, 2023

Uh oh!

ktssr commented May 25, 2023

Uh oh!

ovflowd commented May 25, 2023

Uh oh!

Uh oh!

ktssr commented May 8, 2023 •

edited

Loading

vercel bot commented May 8, 2023 •

edited

Loading

ktssr May 12, 2023 •

edited

Loading