Skip to content

feat: introduce built-in next.js exports and updated scripts and configs #5384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 18, 2023
Merged

feat: introduce built-in next.js exports and updated scripts and configs #5384

merged 8 commits into from
May 18, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented May 18, 2023

This PR simply updates the Next.js configuration/installation and package.json scripts to support the new built-in output: 'exports' from Next.js

A few other optimizations were done such as:

  • next-sitemap configuration to be ModuleJS
  • next-istemap write output to the correct build folder for static builds
  • updated all node imports such as path and fs to have the node: prefix
  • updated contribution guidelines and package.json scripts

@vercel
Copy link

vercel bot commented May 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 18, 2023 8:39pm
nodejs-org-stories ✅ Ready (Inspect) Visit Preview May 18, 2023 8:39pm

@vercel
Copy link

vercel bot commented May 18, 2023

@ovflowd is attempting to deploy a commit to the OpenJS Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@ovflowd ovflowd added the fast-track Fast Tracking PRs label May 18, 2023
@ovflowd
Copy link
Member Author

ovflowd commented May 18, 2023

FYI @nodejs/website markin this as fast-track please give +1 for a quick merge

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 18, 2023 16:50 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 18, 2023 16:54 Inactive
@AugustinMauroy
Copy link
Member

Why remove Robot ?

@ovflowd
Copy link
Member Author

ovflowd commented May 18, 2023

Why remove Robot ?

Because it is a generated file. It was committed accidentally a long time ago.

@AugustinMauroy
Copy link
Member

Ok good, thanks for the clarification !

@ovflowd
Copy link
Member Author

ovflowd commented May 18, 2023

We might want to update this PR once iamvishnusankar/next-sitemap#638 gets released on [email protected]

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 18, 2023 20:34 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 18, 2023 20:35 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories May 18, 2023 20:38 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org May 18, 2023 20:39 Inactive
@ovflowd ovflowd enabled auto-merge (squash) May 18, 2023 20:41
@ovflowd ovflowd disabled auto-merge May 18, 2023 20:41
@ovflowd ovflowd merged commit 1a96f18 into nodejs:main May 18, 2023
@ovflowd ovflowd deleted the feat/built-in-static-exports branch May 18, 2023 20:41
ovflowd added a commit that referenced this pull request May 19, 2023
* feat: introduce built-in next.js exports and updated scripts and configs (#5384)

* chore: updated gitignore and rmeoved robots.txt

* chore: updated next-sitemap config

* chore: next-config refactored options and export support

* chore: updated imports to node: prefix

* chore: updated contributing guidelines

* chore: updated scripts

* chore: updated next-sitemap

* chore: added missing props

* fix: github-pages

* chore: remove unused package

* fix(storybook): update packages (#5386)

---------

Co-authored-by: Harkunwar Kochar <[email protected]>
ovflowd added a commit that referenced this pull request May 24, 2023
* feat: introduce built-in next.js exports and updated scripts and configs (#5384)

* chore: updated gitignore and rmeoved robots.txt

* chore: updated next-sitemap config

* chore: next-config refactored options and export support

* chore: updated imports to node: prefix

* chore: updated contributing guidelines

* chore: updated scripts

* chore: updated next-sitemap

* chore: added missing props

* fix: github-pages

* chore: remove unused package

* fix(storybook): update packages (#5386)

---------

Co-authored-by: Harkunwar Kochar <[email protected]>
ovflowd added a commit that referenced this pull request May 24, 2023
* feat: introduce built-in next.js exports and updated scripts and configs (#5384)

* chore: updated gitignore and rmeoved robots.txt

* chore: updated next-sitemap config

* chore: next-config refactored options and export support

* chore: updated imports to node: prefix

* chore: updated contributing guidelines

* chore: updated scripts

* chore: updated next-sitemap

* chore: added missing props

* fix: github-pages

* chore: remove unused package

* fix(storybook): update packages (#5386)

---------

Co-authored-by: Harkunwar Kochar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants