feat: migrate codebox component #5330
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@araujogui please run |
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
ovflowd
reviewed
Apr 27, 2023
There was a problem hiding this comment.
Really good stuff! Thank you for the contribution, @araujogui!!
Left a bunch of comments that I'd like to have them addressed before we proceed :)
|
@araujogui can you run the linting commands and update the test snapshots here? @Harkunwar is anything else needed here? (Like Unit Tests or etc) |
|
@araujogui can you please run build/lint/test before committing? PR is still failing (build failing) with missing types? |
Signed-off-by: Claudio Wunder <[email protected]>
ovflowd
reviewed
May 18, 2023
ovflowd
added a commit
that referenced
this pull request
May 24, 2023
* feat: create codebox component * feat: add pointer to copy button * feat: add shell support * feat: use code element instead of pre * chore: fix eslint issues * refactor: remove shell codebox * refactor: use react.fc type * refactor: remove duplicate encoding * refactor: use pre element for codebox * style: some eol * style: some eol * refactor: use pre element for codebox * chore: create inlinecode story * refactor: create inline code story type * chore: revert .browserslistrc * test: remove duplicated test * test: remove beginning space on code * refactor: setup userEvent on tests * refactor: remove useless async * test: manual mock isomorphic-dompurify * fix: some fixes * chore: create multi lang story * test: snapshot before and after switch lang * refactor: inline mock * refactor: use decorators * chore: split inlinecode component * feat: add selected lang state * refactor: add inlinecode decorator * refactor: remove duplicate classes * chore: revert .browserslistrc * test: fix tests * chore: wip * feat: use story component arg * style: stories * test: remove i18n from clipboard test * chore: migrate pagination component (#5331) Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * chore: add a proper decorated component * refactor: decorated inline code * Chore(node feat) (#5338) Co-authored-by: Claudio Wunder <[email protected]> * (website redesign) Feat(shellbox): migration (#5234) Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * fix(i18n): translation key (#5347) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * feat: add hover states * chore: fix rebase leftovers * chore: update snapshots * chore: install @types/prismjs * Update index.stories.tsx Signed-off-by: Claudio Wunder <[email protected]> * chore: remove duplicate snapshots * chore: remove duplicate snapshot --------- Signed-off-by: Claudio Wunder <[email protected]> Co-authored-by: ktssr <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]>
ovflowd
added a commit
that referenced
this pull request
May 24, 2023
* feat: create codebox component * feat: add pointer to copy button * feat: add shell support * feat: use code element instead of pre * chore: fix eslint issues * refactor: remove shell codebox * refactor: use react.fc type * refactor: remove duplicate encoding * refactor: use pre element for codebox * style: some eol * style: some eol * refactor: use pre element for codebox * chore: create inlinecode story * refactor: create inline code story type * chore: revert .browserslistrc * test: remove duplicated test * test: remove beginning space on code * refactor: setup userEvent on tests * refactor: remove useless async * test: manual mock isomorphic-dompurify * fix: some fixes * chore: create multi lang story * test: snapshot before and after switch lang * refactor: inline mock * refactor: use decorators * chore: split inlinecode component * feat: add selected lang state * refactor: add inlinecode decorator * refactor: remove duplicate classes * chore: revert .browserslistrc * test: fix tests * chore: wip * feat: use story component arg * style: stories * test: remove i18n from clipboard test * chore: migrate pagination component (#5331) Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * chore: add a proper decorated component * refactor: decorated inline code * Chore(node feat) (#5338) Co-authored-by: Claudio Wunder <[email protected]> * (website redesign) Feat(shellbox): migration (#5234) Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Wai.Tung <[email protected]> * fix(i18n): translation key (#5347) Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> * feat: add hover states * chore: fix rebase leftovers * chore: update snapshots * chore: install @types/prismjs * Update index.stories.tsx Signed-off-by: Claudio Wunder <[email protected]> * chore: remove duplicate snapshots * chore: remove duplicate snapshot --------- Signed-off-by: Claudio Wunder <[email protected]> Co-authored-by: ktssr <[email protected]> Co-authored-by: Teja Sai Sandeep Reddy Konala <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Wai.Tung <[email protected]> Co-authored-by: Claudio Wunder <[email protected]> Co-authored-by: Augustin Mauroy <[email protected]> Co-authored-by: Manish Kumar ⛄ <[email protected]> Co-authored-by: Shanmughapriyan S <[email protected]> Co-authored-by: Michael Esteban <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5242
Migrate Codebox component