-
Notifications
You must be signed in to change notification settings - Fork 895
fix(iphone-15-pro): resolve iOS device video masking issue with DOM overlay (breaking change) #780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(iphone-15-pro): resolve iOS device video masking issue with DOM overlay (breaking change) #780
Conversation
|
@Yeom-JinHo is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
|
I’ve deployed the updated version to my live site, where you can check it: |
|
I’ve been trying to find a way to fix this without introducing a breaking change and without significantly altering the structure, but I couldn’t find a better solution than this modification. In a mobile-first world, I believe this change is both necessary and important! |
caf9759 to
53e93a1
Compare
…ect> with overlay
53e93a1 to
6ed59cf
Compare
|
thanks i like this approach, solves the issue nicely |
Description
This PR focuses on fixing iOS compatibility issues in the
Iphone15Procomponent.Because mobile-first is the priority, this fix introduces a breaking change to ensure stable rendering across devices.
fixed #753
Changes
<foreignObject>video rendering with a DOM overlay to solve Safari/iOS masking issues.widthandheightprops. The component size is now controlled by the wrapper<div>, enforcing the aspect ratio433/882.srcorvideoSrc) is provided. Without media, only the frame is rendered.HTMLDivElementprops.mutedandplaysInlineto allow autoplay on mobile. Apostercan be added for better initial paint.aria-hidden="true"to the wrapper<div>for compliance.Motivation
Breaking Changes
widthandheightprops fromIphone15Pro.→ Consumers must now control size via wrapper CSS (e.g.,
w-[300px],max-w-full, etc.).width/heightprops will need to migrate.Screenshots