feat(iphone-15-pro): add webviewSrc media option and fix aspect ratio
#804
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
webviewSrcand update props - Introduced a newwebviewSrcprop to support iframes, and renamedsrctoimageSrcprop for clarityfix aspect ratio: demo video
webviewSrcprop: demo videoNotes
The current imp doesn't yet cover all edges cases, for example, issues may arise with internal frame src values, safari has more specific rendering quirks, also a fallback should be added when no src is provided (since src opts are all optional params), wrappnig the whole svg in a outer div with adjustments could improve the rendering, especially on iframes.
I decided left these improvements our of this PR to keep the scope focused, but they're on the roadmap.
Related
btw, @dillionverma — MagicUI is brilliant work! 🎉