feat(iphone-15-pro): add webviewSrc media option and fix iphone aspect ratio
#791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ladunjexa is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
ladunjexa
changed the title
webviewSrc media option and fix iphone aspecr ratios.webviewSrc media option and fix iphone aspect ratio
* fix: update terminal demo * fix: update
* chore: cleanup unused code * chore: remove cli scripts * chore: cleanup import / exports
* feat: add turborepo * fix: bump pnpm version * fix: bump package versions * fix: update lockfile
* chore: fix build + update packages * fix: update build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
webviewSrcand update props - Introduced a newwebviewSrcprop to support iframes, and renamedsrctoimageSrcprop for clarity demo videoNotes
The current imp doesn't yet cover all edges cases, for example, issues may arise with internal frame src values, safari has more specific rendering quirks, also a fallback should be added when no src is provided (since src opts are all optional params), wrappnig the whole svg in a outer div with adjustments could improve the rendering, especially on iframes.
I decided left these improvements our of this PR to keep the scope focused, but they're on the roadmap.
Related
btw, @dillionverma — MagicUI is brilliant work! 🎉