commander: accelerometer calibration respect rotation

[dagar]

• accel cal use Accelerometer calibration class to fully respect rotation (both internal and external sensors)

[github-actions]

🔎 FLASH Analysis

px4_fmu-v5x [Total VM Diff: 64 byte (0 %)]

    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +64  +0.0%     +64    .text
  +4.1%     +84  +4.1%     +84    ../../src/lib/wind_estimator/WindEstimator.cpp
  +0.9%     +64  +0.9%     +64    ../../src/modules/commander/mag_calibration.cpp
  +1.1%     +56  +1.1%     +56    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
  +1.1%     +56  +1.1%     +56    ../../src/modules/fw_att_control/FixedwingAttitudeControl.cpp
  +0.0%      +5  +0.0%      +5    [section .text]
  +0.3%      +4  +0.3%      +4    ../../src/modules/commander/airspeed_calibration.cpp
  +0.2%      +3  +0.2%      +3    ../../src/systemcmds/ver/ver.cpp
  -0.1%      -4  -0.1%      -4    ../../src/modules/commander/failsafe/framework.cpp
  -3.7%    -204  -3.7%    -204    ../../src/modules/commander/accelerometer_calibration.cpp
+0.0%     +62  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
  +0.2%      +6  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
-0.0%     -40  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
 -13.3%     -32  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
-0.0%     -84  [ = ]       0    .debug_frame
-0.0% -1.13Ki  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  -1.7% -1.12Ki  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
-0.0%    -210  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  -1.5%    -189  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
  +0.4%      +4  [ = ]       0    task/task_cancelpt.c
-0.0%    -790  [ = ]       0    .debug_loc
  -2.4%    -766  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
  -0.0%     -24  [ = ]       0    [section .debug_loc]
+0.0%    +119  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
  +1.9%    +128  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
  -1.5%      -1  [ = ]       0    task/task_cancelpt.c
+0.0%      +7  [ = ]       0    .debug_str
  -1.9%    -195  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
  +0.4%     +13  [ = ]       0    ../../src/modules/commander/gyro_calibration.cpp
   +12%    +118  [ = ]       0    ../../src/modules/commander/level_calibration.cpp
  +1.5%     +71  [ = ]       0    ../../src/modules/commander/mag_calibration.cpp
+0.5%      +1  [ = ]       0    .shstrtab
+0.0%     +11  [ = ]       0    .strtab
  -8.1%     -32  [ = ]       0    ../../src/lib/version/version.c
   +17%     +60  [ = ]       0    ../../src/lib/wind_estimator/WindEstimator.cpp
 -15.7%    -217  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
  +9.2%     +60  [ = ]       0    ../../src/modules/commander/mag_calibration.cpp
  +4.5%     +34  [ = ]       0    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
  +3.6%     +74  [ = ]       0    ../../src/modules/fw_att_control/FixedwingAttitudeControl.cpp
  +0.0%     +32  [ = ]       0    [section .strtab]
-0.4%     -64  [ = ]       0    [Unmapped]
-0.0% -2.03Ki  +0.0%     +64    TOTAL

px4_fmu-v6x [Total VM Diff: 56 byte (0 %)]

    FILE SIZE        VM SIZE    
--------------  -------------- 
+0.0%     +56  +0.0%     +56    .text
  +4.1%     +84  +4.1%     +84    ../../src/lib/wind_estimator/WindEstimator.cpp
  +0.9%     +64  +0.9%     +64    ../../src/modules/commander/mag_calibration.cpp
  +1.1%     +56  +1.1%     +56    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
  +1.1%     +56  +1.1%     +56    ../../src/modules/fw_att_control/FixedwingAttitudeControl.cpp
  +0.3%      +4  +0.3%      +4    ../../src/modules/commander/airspeed_calibration.cpp
  -0.1%      -4  -0.1%      -4    ../../src/modules/commander/failsafe/framework.cpp
  -3.7%    -204  -3.7%    -204    ../../src/modules/commander/accelerometer_calibration.cpp
+0.0%     +62  [ = ]       0    .debug_abbrev
   +11%     +56  [ = ]       0    ../../src/lib/version/version.c
  +0.2%      +6  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
-0.0%     -40  [ = ]       0    .debug_aranges
  -5.0%      -8  [ = ]       0    ../../src/lib/version/version.c
 -13.3%     -32  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
-0.0%     -84  [ = ]       0    .debug_frame
-0.0% -1.13Ki  [ = ]       0    .debug_info
  -0.2%      -4  [ = ]       0    ../../src/lib/version/version.c
  -1.7% -1.12Ki  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
-0.0%    -218  [ = ]       0    .debug_line
  -1.3%     -25  [ = ]       0    ../../src/lib/version/version.c
  -1.5%    -189  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
  -0.4%      -4  [ = ]       0    task/task_cancelpt.c
-0.0%    -805  [ = ]       0    .debug_loc
  -2.4%    -781  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
  -0.0%     -24  [ = ]       0    [section .debug_loc]
+0.0%    +118  [ = ]       0    .debug_ranges
  -2.6%      -8  [ = ]       0    ../../src/lib/version/version.c
  +1.9%    +128  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
  -3.0%      -2  [ = ]       0    task/task_cancelpt.c
+0.0%      +7  [ = ]       0    .debug_str
  -1.9%    -195  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
  +0.4%     +13  [ = ]       0    ../../src/modules/commander/gyro_calibration.cpp
   +11%    +118  [ = ]       0    ../../src/modules/commander/level_calibration.cpp
  +1.5%     +71  [ = ]       0    ../../src/modules/commander/mag_calibration.cpp
+0.5%      +1  [ = ]       0    .shstrtab
+0.0%     +11  [ = ]       0    .strtab
  -8.1%     -32  [ = ]       0    ../../src/lib/version/version.c
   +17%     +60  [ = ]       0    ../../src/lib/wind_estimator/WindEstimator.cpp
 -15.7%    -217  [ = ]       0    ../../src/modules/commander/accelerometer_calibration.cpp
  +9.2%     +60  [ = ]       0    ../../src/modules/commander/mag_calibration.cpp
  +4.3%     +34  [ = ]       0    ../../src/modules/ekf2/EKF/yaw_estimator/EKFGSF_yaw.cpp
  +3.6%     +74  [ = ]       0    ../../src/modules/fw_att_control/FixedwingAttitudeControl.cpp
  +0.0%     +32  [ = ]       0    [section .strtab]
-0.1%     -56  [ = ]       0    [Unmapped]
-0.0% -2.05Ki  +0.0%     +56    TOTAL

Updated: 2024-12-16T19:30:32

[AlexKlimaj]

Tested with an ARV6X and external Murata IMU. ARKV6X has a SENS_BOARD_ROT and the external IMU has no rotation. Previously, calibration would fail as SENS_BOARD_ROT was applied to the external IMU during calibration. Now this is working.