Skip to content

exclude box and block glyphs from contrast ratio demands #3844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meganrogge merged 6 commits into from
Jun 2, 2022
Merged

exclude box and block glyphs from contrast ratio demands #3844

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2d545fe
fix #3843
meganrogge May 31, 2022
182f98a
add block range
meganrogge Jun 1, 2022
902ea76
Update src/browser/renderer/RendererUtils.ts
meganrogge Jun 1, 2022
a1b15fa
limit range for powerline glyphs
meganrogge Jun 1, 2022
a0e4ac0
Merge branch 'color-contrast' of https://github.com/meganrogge/xterm.…
meganrogge Jun 1, 2022
cf3efe2
skip tests
meganrogge Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/browser/renderer/RendererUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ export function isPowerlineGlyph(codepoint: number): boolean {
return 0xE0A0 <= codepoint && codepoint <= 0xE0D6;
}

function isBoxGlyph(codepoint: number): boolean {
return 0x2500 <= codepoint && codepoint <= 0x257F;
function isBoxOrBlockGlyph(codepoint: number): boolean {
return (0x2500 <= codepoint && codepoint <= 0x257F) || (0x2580 <= codepoint && codepoint <= 0x259F);
}

export function excludeFromContrastRatioDemands(codepoint: number): boolean {
return isPowerlineGlyph(codepoint) || isBoxGlyph(codepoint);
return isPowerlineGlyph(codepoint) || isBoxOrBlockGlyph(codepoint);
}