exclude box and block glyphs from contrast ratio demands #3844
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meganrogge
commented
May 31, 2022
meganrogge
changed the title
Tyriar
approved these changes
Jun 1, 2022
Tyriar
requested changes
Jun 1, 2022
Member
Tyriar
left a comment
Tyriar
left a comment
There was a problem hiding this comment.
We should actually not be excluding some of the powerline symbols, the ones that are just icons (0xe0a0-0xe0a3):
Member
|
Ha, the tests failed because it's a block character used in the webgl api tests. You can skip the test and create an issue to handle in debt week. |
Co-authored-by: Daniel Imms <[email protected]>
… into color-contrast
Tyriar
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3843