Make ResticIdentifier optional for kopia BackupRepositories #8987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8987 +/- ##
=======================================
Coverage 59.07% 59.07%
=======================================
Files 379 379
Lines 43511 43518 +7
=======================================
+ Hits 25702 25709 +7
Misses 16281 16281
Partials 1528 1528 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lyndon-Li
reviewed
May 30, 2025
sseago
previously approved these changes
Jul 9, 2025
sseago
previously approved these changes
Jul 22, 2025
kaovilai
force-pushed
the
velero-8830
branch
2 times, most recently
from
f456421 to
c1211f1
Compare
shubham-pampattiwar
approved these changes
Jul 23, 2025
Lyndon-Li
approved these changes
Jul 24, 2025
The ResticIdentifier field in BackupRepository is only relevant for restic repositories. For kopia repositories, this field is unused and should be omitted. This change: - Adds omitempty tag to ResticIdentifier field in BackupRepository CRD - Updates controller to only populate ResticIdentifier for restic repos - Adds tests to verify behavior for both restic and kopia repository types This ensures backward compatibility while properly handling kopia repositories that don't require a restic-compatible identifier. Signed-off-by: Tiger Kaovilai <[email protected]>
3 tasks
MaloLelandais
pushed a commit
to MaloLelandais/velero
that referenced
this pull request
Jul 28, 2025
) The ResticIdentifier field in BackupRepository is only relevant for restic repositories. For kopia repositories, this field is unused and should be omitted. This change: - Adds omitempty tag to ResticIdentifier field in BackupRepository CRD - Updates controller to only populate ResticIdentifier for restic repos - Adds tests to verify behavior for both restic and kopia repository types This ensures backward compatibility while properly handling kopia repositories that don't require a restic-compatible identifier. Signed-off-by: Tiger Kaovilai <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make ResticIdentifier optional for kopia repositories
Signed-off-by: Tiger Kaovilai [email protected]
Thank you for contributing to Velero!
Please add a summary of your change
The ResticIdentifier field in BackupRepository is only relevant for restic repositories. For kopia repositories, this field is unused and should be omitted.
This change:
This ensures backward compatibility while properly handling kopia repositories that don't require a restic-compatible identifier.
Does your change fix a particular issue?
Fixes #8830
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.