fix the resticIdentifier value #7597
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: muxuelan <[email protected]>
Contributor
|
Have you considered creating a dedicated type for this purpose ? |
Author
yes, hold on |
Collaborator
|
resticIdentifier is there for backwards compatibility and not used by kopia file system backup process. It's an ignored field for kopia afaict. |
Contributor
|
Kopia path doesn't use repoIdentifier, and so this field will be removed/reused after Restic path is totally deprecated. Therefore, we can hold on the changes to repoIdentifier until we know how to reuse /whether to remove it after Restic path is deprecated. |
Collaborator
|
since #8987 merged, it's clear we do not need this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、while repositoryType is "kopia"，resticIdentifier value should match
2、for s3 such as minio，url shoud be http://s3_url/buckets/bucketName/..., not http://s3_url/bucketName/...