Skip to content

Conversation

@vitess-bot
Copy link
Contributor

@vitess-bot vitess-bot bot commented Dec 12, 2025

Description

This is a backport of #19015

@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Dec 12, 2025

Hello @timvaillancourt, there are conflicts in this backport.

Please address them in order to merge this Pull Request. You can execute the snippet below to reset your branch and resolve the conflict manually.

Make sure you replace origin by the name of the vitessio/vitess remote

git fetch --all
gh pr checkout 19021 -R vitessio/vitess
git reset --hard origin/release-22.0
git cherry-pick -m 1 802b55e2a70dbb32d49faf95f52a561cb0663ec4

@vitess-bot vitess-bot bot added Skip CI Skip CI actions from running Component: Docker Merge Conflict labels Dec 12, 2025
@vitess-bot
Copy link
Contributor Author

vitess-bot bot commented Dec 12, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

google.golang.org/api v0.226.0
google.golang.org/genproto v0.0.0-20250313205543-e70fdf4c4cb4 // indirect
google.golang.org/grpc v1.71.0
google.golang.org/grpc v1.71.1
Copy link
Contributor

@timvaillancourt timvaillancourt Dec 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

go mod tidy is insisting on this and when I revert it, it puts it back. Let me know if this is a concern

@timvaillancourt timvaillancourt marked this pull request as ready for review December 12, 2025 21:30
@timvaillancourt timvaillancourt enabled auto-merge (squash) December 12, 2025 21:30
@timvaillancourt timvaillancourt self-requested a review December 12, 2025 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants